Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving test coverage for PEcAn.DB package #3180

Merged
merged 25 commits into from
Aug 27, 2023
Merged

Improving test coverage for PEcAn.DB package #3180

merged 25 commits into from
Aug 27, 2023

Conversation

meetagrawal09
Copy link
Collaborator

Description

PR aims at improving unit test coverage for PEcAn.DB package

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meetagrawal09 meetagrawal09 marked this pull request as draft June 7, 2023 12:55
@meetagrawal09 meetagrawal09 changed the title Improve test coverage for PEcAn.DB package Improving test coverage for PEcAn.DB package Jun 7, 2023
@infotroph infotroph self-requested a review June 29, 2023 16:04
@meetagrawal09 meetagrawal09 marked this pull request as ready for review August 18, 2023 12:06
@mdietze mdietze added this pull request to the merge queue Aug 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2023
@mdietze mdietze added this pull request to the merge queue Aug 27, 2023
Merged via the queue into PecanProject:develop with commit 9ea1382 Aug 27, 2023
12 checks passed
@meetagrawal09 meetagrawal09 deleted the test-db branch August 28, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdietze mdietze mdietze approved these changes

@infotroph infotroph Awaiting requested review from infotroph

Assignees
No one assigned
Labels
Topic: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meetagrawal09 @mdietze