Add an option to choose websocket protocol #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the default is wss this is needed to test with local servers
PartMan7
requested changes
May 18, 2024
|
Could you also update the docs in the README for this? |
PartMan7
approved these changes
May 18, 2024
PartMan7
requested changes
May 18, 2024
|
Also I should probably add a |
|
This seems to be passing locally; not sure why CI is failing for this Merging for now; will address fixes if needed |
|
Published in 3.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that wss is the default this change is needed to support insecure servers
Needed the tests change for the pre-commit hook to work