Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile ps-client for browser #11

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

singiamtel
Copy link
Collaborator

Had to change inline-css for juice as it didn't compile through browserify properly, but it seems to work fine

Copy link
Owner

@PartMan7 PartMan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a first glance; will test and get back

@PartMan7
Copy link
Owner

Hi have completed lightning-fast tests

@singiamtel
Copy link
Collaborator Author

I'm not sure if it's working properly even if it compiles tbh, I think we should scrap this

@PartMan7
Copy link
Owner

Need to run in the browser once, but the juice change in particular is appreciated

@PartMan7 PartMan7 added enhancement New feature or request help wanted Extra attention is needed labels Jan 31, 2024
@singiamtel
Copy link
Collaborator Author

singiamtel commented Jul 11, 2024

Need to run in the browser once, but the juice change in particular is appreciated

@PartMan7 I don't think the browser side of the PR is ready to be merged, should I close the PR? I can repurpose it to only include the juice change if you want (and fix the merge issues)

@PartMan7
Copy link
Owner

I have a local version of this checked out with planned fixes; had some weird failures there. Can push to some other branch as reference when I get home today if you'd like.

If you'd like to try doing this again on this PR that works out great too; haven't had the time to focus on fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants