-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile ps-client for browser #11
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a first glance; will test and get back
Hi have completed lightning-fast tests |
I'm not sure if it's working properly even if it compiles tbh, I think we should scrap this |
Need to run in the browser once, but the juice change in particular is appreciated |
@PartMan7 I don't think the browser side of the PR is ready to be merged, should I close the PR? I can repurpose it to only include the juice change if you want (and fix the merge issues) |
I have a local version of this checked out with planned fixes; had some weird failures there. Can push to some other branch as reference when I get home today if you'd like. If you'd like to try doing this again on this PR that works out great too; haven't had the time to focus on fixing that. |
Had to change
inline-css
forjuice
as it didn't compile through browserify properly, but it seems to work fine