feat(Customer Form): Sales Tax and Template (Functionality) #126 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaiFi0102
requested changes
Apr 3, 2024
Comment on lines
+288
to
+293
| if source_doc.get("customer") and source_doc.get("company"): | ||
| if frappe.get_cached_value("Customer", source_doc.get("customer"), "taxes_and_charges_template"): | ||
| from erpnext.accounts.party import set_taxes | ||
| from erpnext.accounts.doctype.sales_invoice.pos import update_tax_table | ||
| target_doc.taxes_and_charges = set_taxes(source_doc.get("customer"), "Customer", source_doc.get("posting_date"), source_doc.get("company")) | ||
| update_tax_table(target_doc) |
There was a problem hiding this comment.
- Duplicated logic .. you have already implemented logic to determine taxes and charges based on customer and tax rules, do not reimplement it
- The idea is to use the same method that sets taxes and charges based on customer and tax rules
- Explore and use
TransactionController.reset_taxes_and_chargesin https://github.com/ParaLogicTech/erpnext/blob/1a46d40bd3675ba49cdafb768d4d967768431abd/erpnext/controllers/transaction_controller.py#L725 - For reference, this is already implemented in https://github.com/ParaLogicTech/erpnext/blob/1a46d40bd3675ba49cdafb768d4d967768431abd/erpnext/projects/doctype/project/project.py#L2130
revert everything
|
Wrong app. Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ParaLogicTech/erpnext#332