feat: 接入 scowd #1193
Merged
feat: 接入 scowd #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0b276b The changes in this PR will be included in the next version bump. This PR includes changesets to release 19 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ddadaal
requested changes
Apr 18, 2024
apps/portal-server/src/config/env.ts
Outdated
| @@ -30,6 +30,13 @@ export const config = envConfig({ | |||
| SSH_PUBLIC_KEY_PATH: str({ desc: "SSH公钥路径", default: join(homedir(), ".ssh", "id_rsa.pub") }), | |||
|
|
|||
| DOWNLOAD_CHUNK_SIZE: num({ desc: "grpc下载文件时，每个message中的chunk的大小。单位字节", default: 3 * 1024 * 1024 }), | |||
|
|
|||
| SCOWD_ENABLED: bool({ desc: "是否开启 SCOWD", default: false }), | |||
There was a problem hiding this comment.
现在实际上调用的grpc service是多态的，是否启用scowd影响不同的service，但是更好的方式应该是抽象在clusterops部分，apps/portal-server/src/clusterops这里已经为job和app定义了接口，job和app部分的grpc service会调用clusterops部分的逻辑，不同的cluster可以用不同的clusterops逻辑。这样可以支持有的cluster启用了scowd，有的没有的场景
Comment on lines
48
to
49
| // 函数将 Code 转换为 @grpc/grpc-js 的 status | ||
| export function convertCodeToGrpcStatus(code: Code): status { |
There was a problem hiding this comment.
这个翻了一下文档，只看到 转为 http 的 status code 的，没找到转为 grpc 的
There was a problem hiding this comment.
可以去对比一下，connect的code和grpc的code定义是一模一样的，不需要转换
ddadaal
requested changes
Apr 27, 2024
Comment on lines
43
to
45
| export const getScowdClient = (cluster: string) => { | ||
| return scowdClientForClusters[cluster]; | ||
| }; |
There was a problem hiding this comment.
如果所有getScowdClient的调用都会在返回undefined的时候报错，可以把异常直接写在这个函数里，即使不是，也需要显式指定返回值为可能是undefined的，以免调用者忘记处理undefined的情况。
pkuhpc-review-bot
bot
added
Code-ChangeRequested
and removed
Code-ReviewRequested
pkuhpc-review-bot
bot
added
Code-ReviewRequested
ddadaal
approved these changes
Jun 12, 2024
pkuhpc-review-bot
bot
added
Code-Approved
lyl-available
approved these changes
Jun 14, 2024
pkuhpc-review-bot
bot
added
E2E-Approved
OYX-1
pushed a commit
that referenced
this pull request
Jul 4, 2024
完成 scow 对接 scowd 一期的改造，主要完成 HPC 文件和桌面相关功能改造 --------- Co-authored-by: Chen Junda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
完成 scow 对接 scowd 一期的改造，主要完成 HPC 文件和桌面相关功能改造