Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix support for Squiz.Operators.ValidLogicalOperatorsSniff #613

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Koopzington
Copy link

Description

Here's my slightly belated retarget of squizlabs/PHP_CodeSniffer#1370
The changes enable autofixing for cases where code behaviour won't change by replacing and with && as well as or with ||.

Suggested changelog entry

Added

  • The following sniff(s) have received autofix support:
    • Squiz.Operators.ValidLogicalOperatorsSniff

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant