Squiz/DisallowMultipleAssignments: bug fix - dynamic property assignment on object stored in array #610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
GaryJones
approved these changes
Sep 9, 2024
…ent on object stored in array The sniff would try to find whether the first "relevant" variable found matches the start of the statement and if not, throw an error, but in the case of dynamic property access on objects stored in an array, the first "relevant" variable determination was off and would get stuck on the `]` close bracket of the array access. Fixed now. Includes ample tests. This should also make the sniff slightly more efficient for property access code snippets which the sniff already handled correctly. Fixes 598
jrfnl
force-pushed
the
feature/598-squiz-disallowmultipleassignments-bug-fix
branch
from
5396872
to
0ab692a
Compare
|
Rebased without changes. Merging once the build has passed. |
jrfnl
deleted the
feature/598-squiz-disallowmultipleassignments-bug-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sniff would try to find whether the first "relevant" variable found matches the start of the statement and if not, throw an error, but in the case of dynamic property access on objects stored in an array, the first "relevant" variable determination was off and would get stuck on the
]close bracket of the array access.Fixed now. Includes ample tests.
This should also make the sniff slightly more efficient for property access code snippets which the sniff already handled correctly.
Suggested changelog entry
Fixed `Squiz.PHP.DisallowMultipleAssignments false positive on assignments to variable property on object stored in array
Related issues/external references
Fixes #598
Types of changes