Fixed pattern replacements in Filter.php #602
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bad pattern replacements. Eliminates warnings when used as PHP Sniffer extension in VSCode.
Description
If full Windows path is used as ignore filter in shouldIgnorePath() function, then conversion to PREG pattern was buggy.
Windows backslash separator should be converted into double backslash (escaped backslash) AND Linux slash separator should be converted into double backslash.
Suggested changelog entry
Add backslash into double backslash replacement for Windows.
Related issues/external references
PHP Sniffer extension for VSCode generates warnings on Windows without this fix.
Types of changes
PR checklist