Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ New Generic.WhiteSpace.HereNowdocIdentifierSpacing sniff #586

Merged

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 31, 2024

Description

New Generic.WhiteSpace.HereNowdocIdentifierSpacing sniff which forbids whitespace between the <<< and the identifier string in heredoc/nowdoc start tokens.

Includes fixer.
Includes tests.
Includes XML docs.

Suggested changelog entry

New Generic.WhiteSpace.HereNowdocIdentifierSpacing sniff which forbids whitespace between the <<< and the identifier string in heredoc/nowdoc start tokens.

Related issues/external references

#585

Types of changes

  • New feature (non-breaking change which adds functionality)

@jrfnl
Copy link
Member Author

jrfnl commented Jul 31, 2024

@rikvdh ☝️ Might also be something to suggest to PER ? Don't think this is covered in the PER standard yet.

New `Generic.WhiteSpace.HereNowdocIdentifierSpacing` sniff which forbids whitespace between the `<<<` and the identifier string in heredoc/nowdoc start tokens.

Includes fixer.
Includes tests.
Includes XML docs.
@jrfnl jrfnl force-pushed the feature/new-generic-heredocnowdocidentifierspacing-sniff branch from d802443 to 1234504 Compare September 18, 2024 12:19
@jrfnl
Copy link
Member Author

jrfnl commented Sep 18, 2024

Rebased without changes.

@jrfnl jrfnl merged commit 40f1a55 into master Sep 29, 2024
49 checks passed
@jrfnl jrfnl deleted the feature/new-generic-heredocnowdocidentifierspacing-sniff branch September 29, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant