Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic/SpreadOperatorSpacingAfter: move parse error test to its own file #539

Conversation

biinari
Copy link
Contributor

@biinari biinari commented Jul 13, 2024

Description

Suggested changelog entry

N/A

Related issues/external references

See #143

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 I'll merge this once the build has passed.
Thanks for contributing @biinari!

@biinari
Copy link
Contributor Author

biinari commented Jul 13, 2024

Thanks @jrfnl. I have a couple more on their way for tonight (I started with comments that indicated they needed to be the last in the file).

@jrfnl
Copy link
Member

jrfnl commented Jul 13, 2024

@biinari That's awesome! I may not get to them all tonight, but will review those tomorrow in that case. Thanks for your willingness to help the project!

@jrfnl jrfnl merged commit 0b67d68 into PHPCSStandards:master Jul 13, 2024
42 checks passed
@biinari biinari deleted the chore/143-Generic_SpreadOperatorSpacingAfter_separate_parse_error branch July 14, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants