Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing '.fixed' file for src/Standards/PEAR/Tests/WhiteSpace/ScopeIndentUnitTest #476

Merged
merged 1 commit into from
May 6, 2024

Conversation

DannyvdSluijs
Copy link
Contributor

Description

As mentioned in #299 there was a missing .fixed file for the unit test in src/Standards/PEAR/Tests/WhiteSpace/ScopeIndentUnitTest. This PR adds the missing file.

Suggested changelog entry

Add missing .fixed file

Related issues/external references

Fixes #299

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

  • I have checked there is no other PR open for the same change.
  • I have read the Contribution Guidelines.
  • I grant the project the right to include and distribute the code under the BSD-3-Clause license (and I have the right to grant these rights).
  • I have added tests to cover my changes.
  • I have verified that the code complies with the projects coding standards.
  • [Required for new sniffs] I have added XML documentation for the sniff.

@jrfnl
Copy link
Member

jrfnl commented May 2, 2024

@DannyvdSluijs Thanks for the PR. Could you please elaborate on how you created the file and how you validated the fixes ? (as per #299)

@DannyvdSluijs
Copy link
Contributor Author

@DannyvdSluijs Thanks for the PR. Could you please elaborate on how you created the file and how you validated the fixes ? (as per #299)

To start I've copied the file and verified it was causing failing test (following red-green principle here) after which I've checked the newly created file seeking the erroneous lines where commented with // error here and manually corrected them.

Since the PHP_CodeSniffer\Standards\PEAR\Sniffs\WhiteSpace\ScopeIndentSniff is extending from the Generic standard but has a overriding setting for nonIndentingScopes I've verified that cases for a missing indent and a correct indent in the scope of a switch statement was included.

@jrfnl jrfnl added this to the 3.10.0 milestone May 6, 2024
Copy link
Member

@jrfnl jrfnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming that @DannyvdSluijs ! Merging now.

@jrfnl jrfnl merged commit 4fd52f7 into PHPCSStandards:master May 6, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests: add missing .fixed files
2 participants