Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0 | Let T_STATIC be T_STATIC #37

Open
wants to merge 1 commit into
base: 4.0
Choose a base branch
from
Open

4.0 | Let T_STATIC be T_STATIC #37

wants to merge 1 commit into from

Commits on Dec 7, 2023

  1. 4.0 | Let T_STATIC be T_STATIC 

    Implementation of the proposal outlined in issue 3115.

1. Removes the Tokenizer/PHP code which made an exception for `instanceof static`.
2. Adds an exception for `instanceof static` to the `Squiz.WhiteSpace.ScopeKeywordSpacing` sniff for which the tokenizer code was originally put in place.

The tests for all other sniffs still pass.

I've had a quick look through the other sniffs which refer to the `T_STATIC` token, but didn't see any which should be impacted by this change (and didn't have unit tests with `instanceof static`).

Fixes 3115
    @jrfnl
    jrfnl committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    67d9752 View commit details
    Browse the repository at this point in the history