Merge pull request #540 from biinari/chore/143-Generic_LowerCaseConst…

…ant_separate_parse_error Generic/LowerCaseConstant: move parse error test to its own file
PHPCSStandards · Jul 13, 2024 · d0a9809 · d0a9809
2 parents 0b67d68 + 0a4e8b9
commit d0a9809
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 9 deletions.
diff --git a/...c/Tests/PHP/LowerCaseConstantUnitTest.inc → ...Tests/PHP/LowerCaseConstantUnitTest.1.inc b/...c/Tests/PHP/LowerCaseConstantUnitTest.inc → ...Tests/PHP/LowerCaseConstantUnitTest.1.inc
@@ -151,7 +151,3 @@ class TypedConstants {
 
 // Global constants can not be typed.
 const MYCONST = TRUE;
-
-// Last coding/parse error.
-// This has to be the last test in the file.
-function UnclosedCurly (): FALSE {
diff --git a/...s/PHP/LowerCaseConstantUnitTest.inc.fixed → ...PHP/LowerCaseConstantUnitTest.1.inc.fixed b/...s/PHP/LowerCaseConstantUnitTest.inc.fixed → ...PHP/LowerCaseConstantUnitTest.1.inc.fixed
@@ -151,7 +151,3 @@ class TypedConstants {
 
 // Global constants can not be typed.
 const MYCONST = true;
-
-// Last coding/parse error.
-// This has to be the last test in the file.
-function UnclosedCurly (): FALSE {
diff --git a/src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.2.inc b/src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.2.inc
@@ -0,0 +1,4 @@
+<?php
+
+// Intentional parse error. Testing that the sniff is *not* triggered in this case.
+function UnclosedCurly (): FALSE {
diff --git a/src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.php b/src/Standards/Generic/Tests/PHP/LowerCaseConstantUnitTest.php
@@ -33,7 +33,7 @@ final class LowerCaseConstantUnitTest extends AbstractSniffUnitTest
     public function getErrorList($testFile='')
     {
         switch ($testFile) {
-        case 'LowerCaseConstantUnitTest.inc':
+        case 'LowerCaseConstantUnitTest.1.inc':
             return [
                 7   => 1,
                 10  => 1,