Merge pull request #545 from biinari/chore/143-Squiz_ControlSignature…

…_separate_parse_error Squiz/ControlSignature: move parse error to its own file
PHPCSStandards · Jul 14, 2024 · 8581f0c · 8581f0c
2 parents fd065a7 + 3798bda
commit 8581f0c
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 11 deletions.
diff --git a/...olStructures/ControlSignatureUnitTest.inc → ...Structures/ControlSignatureUnitTest.1.inc b/...olStructures/ControlSignatureUnitTest.inc → ...Structures/ControlSignatureUnitTest.1.inc
@@ -318,7 +318,3 @@ endif;
 
 // Reset property.
 // phpcs:set Squiz.ControlStructures.ControlSignature requiredSpacesBeforeColon 1
-
-// Intentional parse error. This should be the last test in the file.
-foreach
-   // Some unrelated comment.
diff --git a/...ctures/ControlSignatureUnitTest.inc.fixed → ...ures/ControlSignatureUnitTest.1.inc.fixed b/...ctures/ControlSignatureUnitTest.inc.fixed → ...ures/ControlSignatureUnitTest.1.inc.fixed
@@ -322,7 +322,3 @@ endif;
 
 // Reset property.
 // phpcs:set Squiz.ControlStructures.ControlSignature requiredSpacesBeforeColon 1
-
-// Intentional parse error. This should be the last test in the file.
-foreach
-   // Some unrelated comment.
diff --git a/src/Standards/Squiz/Tests/ControlStructures/ControlSignatureUnitTest.2.inc b/src/Standards/Squiz/Tests/ControlStructures/ControlSignatureUnitTest.2.inc
@@ -0,0 +1,5 @@
+<?php
+
+// Intentional parse error. Live coding resilience.
+foreach
+   // Some unrelated comment.
diff --git a/src/Standards/Squiz/Tests/ControlStructures/ControlSignatureUnitTest.php b/src/Standards/Squiz/Tests/ControlStructures/ControlSignatureUnitTest.php
@@ -55,7 +55,8 @@ public function getErrorList($testFile='')
             112 => 1,
         ];
 
-        if ($testFile === 'ControlSignatureUnitTest.inc') {
+        switch ($testFile) {
+        case 'ControlSignatureUnitTest.1.inc':
             $errors[122] = 1;
             $errors[130] = 2;
             $errors[134] = 1;
@@ -84,9 +85,14 @@ public function getErrorList($testFile='')
             $errors[306] = 3;
             $errors[309] = 1;
             $errors[315] = 1;
-        }//end if
+            return $errors;
 
-        return $errors;
+        case 'ControlSignatureUnitTest.js':
+            return $errors;
+
+        default:
+            return [];
+        }//end switch
 
     }//end getErrorList()