Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCSDebug: fix tests #136

Merged
merged 1 commit into from
Mar 4, 2024
Merged

PHPCSDebug: fix tests #136

merged 1 commit into from
Mar 4, 2024

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Mar 4, 2024

PHPCSUtils 1.0.9 made a change to the UtilityMethodTestCase which causes the selected sniff to no longer register its token listeners as the installed_paths from the CodeSniffer.conf file are no longer read out.

While this is fine for actual utility methods, it breaks the tests for the PHPCSDebug.Debug.TokenList test.

Fixed now.

Refs:

PHPCSUtils 1.0.9 made a change to the `UtilityMethodTestCase` which causes the selected sniff to no longer register its token listeners as the `installed_paths` from the `CodeSniffer.conf` file are no longer read out.

While this is fine for actual utility methods, it breaks the tests for the `PHPCSDebug.Debug.TokenList` test.

Fixed now.
@jrfnl jrfnl added this to the 1.x Next Release milestone Mar 4, 2024
@jrfnl jrfnl merged commit 5c5bdcd into develop Mar 4, 2024
33 checks passed
@jrfnl jrfnl deleted the phpcsdebug/fix-tests branch March 4, 2024 07:01
@jrfnl jrfnl restored the phpcsdebug/fix-tests branch March 4, 2024 07:03
@jrfnl
Copy link
Member Author

jrfnl commented Mar 4, 2024

This was pulled to the wrong branch, replaced by PR #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant