Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fallthroughs explicit encoding.c #377

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make fallthroughs explicit encoding.c #377

wants to merge 1 commit into from

Conversation

r-barnes
Copy link

This allows -Wimplicit-fallthrough to pass on LLVM.

@Leont
Copy link
Contributor

Leont commented Aug 5, 2024

I don't think that's portable, so you need to wrap it in some defines.

@r-barnes
Make fallthroughs explicit encoding.c
f01fa36 
This allows `-Wimplicit-fallthrough` to pass on LLVM.
@r-barnes
Copy link
Author

r-barnes commented Aug 6, 2024

@Leont - I've added a macro for portability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-barnes @Leont