Feature/secure auth #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/build.gradle # app/src/main/AndroidManifest.xml # app/src/main/java/com/otus/securehomework/data/repository/TokenAuthenticator.kt # app/src/main/java/com/otus/securehomework/di/AppModule.kt # app/src/main/java/com/otus/securehomework/di/RemoteDataSource.kt
| @@ -0,0 +1,7 @@ | |||
| package com.otus.securehomework.data.dto | |||
|
|
|||
| data class LoginData(val email: String, val password: String) { | |||
There was a problem hiding this comment.
в идеале пароль поменять из String на CharSequence
| private fun canAuthenticate(authenticator: Int) = BiometricManager.from(context) | ||
| .canAuthenticate(authenticator) == BiometricManager.BIOMETRIC_SUCCESS | ||
|
|
||
| fun ByteArray.toBase64(flags: Int = Base64.DEFAULT): String = Base64.encodeToString(this, flags) |
There was a problem hiding this comment.
Можно эти экстеншены вынести в общие , так как будут переиспользоваться
| @@ -5,14 +5,19 @@ import android.view.View | |||
| import androidx.fragment.app.Fragment | |||
| import androidx.fragment.app.viewModels | |||
| import com.otus.securehomework.R | |||
| import com.otus.securehomework.databinding.FragmentLoginBinding | |||
| val ciphertext = encryptor.doFinal(plaintext.toByteArray()) | ||
| return EncryptedEntity( | ||
| ciphertext, | ||
| encryptor.iv |
There was a problem hiding this comment.
мне кажется странным, возвращать вектор как результат . Класс , который отвечает за шифрование, должен уметь и сохранять вектор безопасно
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created BaseSecurePreferences as EncryptedSharedPreferences, added key creation for api 21+, added fingerprint assigning and validation