Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Farsiyan V. Flow #91

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Farsiyan V. Flow #91

wants to merge 4 commits into from

Conversation

Buzlighter
Copy link

No description provided.

Copy link
Collaborator

@antonkazakov antonkazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Привет. Поправь, пожалуйста, одно замечания

@@ -13,11 +15,20 @@ class CatsViewModel(
private val _catsLiveData = MutableLiveData<Fact>()
val catsLiveData: LiveData<Fact> = _catsLiveData

private val _catsStateFlow = MutableStateFlow<Result<Fact>>(Result.Success(null))
val catsStateFlow: StateFlow<Result<Fact>> = _catsStateFlow

init {
viewModelScope.launch {
withContext(Dispatchers.IO) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У тебя коллектор получается на ИО собирает, нужно сделать так чтобы эмитились айтемы на IO, а собирались на Main

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено

Copy link
Collaborator

@antonkazakov antonkazakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants