Validate binary hash #336
Open
Validate binary hash #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… return it to ForgeBox
lmajano
reviewed
Aug 22, 2024
| @@ -539,6 +543,11 @@ component accessors="true" implements="IEndpointInteractive" { | |||
| throw( 'No download URL provided in #getNamePrefixes()#. Manual install only.', 'endpointException' ); | |||
| } | |||
|
|
|||
| // Validate the binary hash | |||
There was a problem hiding this comment.
@bdw429s does this look good to you?
bdw429s
reviewed
Sep 3, 2024
src/cfml/system/endpoints/HTTP.cfc
Outdated
| @@ -81,7 +81,7 @@ component accessors=true implements="IEndpoint" singleton { | |||
|
|
|||
| // Validate the binary hash | |||
| if( len( binaryHash ) && binaryHash != hash( fileReadBinary( fullPath ), "MD5" ) ) { | |||
| throw( 'The binary hash of the downloaded file does not match the expected hash.', 'endpointException' ); | |||
| throw( 'The hash of the downloaded file [#hash( fileReadBinary( fullPath ))#] doesn''t match the excepted hash [#binaryHash#] #fullPath#', 'endpointException' ); | |||
There was a problem hiding this comment.
Please put the hash in a variable instead of calculating it again. For a large file, this may be a non-trivial operation.
bdw429s
reviewed
Sep 3, 2024
| @@ -339,7 +340,8 @@ or just add DEBUG to the root logger | |||
| installInstructionsFormat = arguments.installInstructionsFormat, | |||
| changeLog = arguments.changeLog, | |||
| changeLogFormat = arguments.changeLogFormat, | |||
| forceUpload = arguments.forceUpload | |||
| forceUpload = arguments.forceUpload, | |||
| binaryHash = arguments.binaryHash | |||
There was a problem hiding this comment.
I assume you've also updated ForgeBox to receive and store this?
|
Can we merge this PR? @bdw429s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.