ticket COMMANDBOX-748: compileDSL compile and jar .java #298
Conversation
BalbinoOrtus
changed the title
src/cfml/system/util/CompileDSL.cfc
Outdated
|
|
||
| setSourcePaths( getSourcePaths().map( function( p ) { | ||
| var currentPath = fileSystemutil.resolvePath( arguments.p, getProjectRoot() ); | ||
| if ( directoryExists( currentPath ) ) { |
There was a problem hiding this comment.
Do you have the notes on how I had said to make this work? It wasn't what you have here.
There was a problem hiding this comment.
@bdw429s dk if this is more or less what we talked: use only file globber on fromsource
check if its a folder or a file
if its a file process if not leave it alone
*.java non recursive
if its a folder then add **.java
**.java recursive
globber with filter out folders, to get only files
src/cfml/system/util/CompileDSL.cfc
Outdated
|
|
||
| writeTempSourceFile( tempSrcFileName ); | ||
|
|
||
| var javacCommand = 'run "#getJavaBinFolder()#javac" "@#tempSrcFileName#" -d #variables.classOutputDirectory# #variables.compileOptionsString#'; |
There was a problem hiding this comment.
Need to account for quotes in #variables.classOutputDirectory#
There was a problem hiding this comment.
@bdw429s do you mean "#variables.classOutputDirectory#" ?
There was a problem hiding this comment.
You tell me. How do you handle a file path argument with spaces in it at the command line? :)
There was a problem hiding this comment.
yes, when it has spaces in the path argument using "path" is the way to go. ok i will add them
BalbinoOrtus
force-pushed
the
dev/commandbox-748
branch
2 times, most recently
from
20588a0
to
1177b0e
Compare
BalbinoOrtus
force-pushed
the
dev/commandbox-748
branch
from
f7cb843
to
8f7fd9b
Compare
BalbinoOrtus
force-pushed
the
dev/commandbox-748
branch
from
1ae8d30
to
100262e
Compare
BalbinoOrtus
force-pushed
the
dev/commandbox-748
branch
from
e3a5109
to
7670a6d
Compare
updating the jar with the resources needed
…ns/commandbox into dev/commandbox-748
No description provided.