Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contentbox 1481 missing icons #563

Merged
merged 50 commits into from
Jul 27, 2023
Merged

Contentbox 1481 missing icons #563

merged 50 commits into from
Jul 27, 2023

Conversation

esmeace
Copy link
Contributor

@esmeace esmeace commented Jul 26, 2023

I created custom icons for the status of content:
image

I resolved the missing icons from the dropdowns:
image
image

I created a custom icon for the Directory Listing and Rename:
image

@esmeace
Added icons for the Media Manager Toolbar. This fixes the missing ico…
e53de1f 
…n for the Create New Folder option.
@esmeace
Added icons to be used in the Create New dropdown.
e6f2ef6
@esmeace
Added the icon that represents "Published."
4824c6c
@esmeace
Added the archive box icon.
baad370
@esmeace
Corrects the missing Import and Export icons from the Bulk actions dr…
c9755b2 
…opdown.
@esmeace
Replaced the font icon with the Icon component.
0c36251
@esmeace
Added icons, to represent the status of content items.
c6f20c0
@esmeace
Switched the Published icon.
11e0917
@esmeace
Switched icons to be consistent with the content status icons.
797787e
@esmeace
Removed no longer needed icon.
5469bdf
@esmeace
Replaced the font icon with the Icon component.
4d908fb
@esmeace
Replaced the font icon with the Icon component. This resolves the mis…
2a84253 
…sing Export icon issue.
@esmeace
Replaced the font icon with the Icon component. This resolves the mis…
a274e35 
…sing Import icon issue.
@esmeace
Added the Edit icon.
556f6a0
@esmeace
Replaced font icon with the Icon component. This resolved the missing…
a17aa74 
… Export icon.
@esmeace
Replaced the font icon with the Icon component.
0fa4ca8
@esmeace
Replaced the font icon with the Icon component.
d6f20df
@esmeace
Replaced the font icon with the Icon component.
95b6676
@esmeace
Replaced font icon with Icon component.
2ea956b
@esmeace
Replaced the font icon with the Icon component.
b74275c
@esmeace
Removed the icon from the heading.
bb3dd9d
@esmeace
Removed font trash icon.
76d58ea
@esmeace
Added ability to set a custom class to the Icon element.
ac6ca29
@esmeace
Replaced the <a> with <button> to allow tabbing to the element. Repla…
73fcc8a 
…ced the Trash font icon with the Icon component.
@esmeace
Replaced the font icon with the Icon component.
0a8f548
@esmeace
Added icons to display in Features column of the Sites page. This res…
50cfd47 
…olves the missing icons.
@esmeace
Removed class.
6fb0a09
@esmeace
Added icons for the Display Options and Open Site.
a251052
@esmeace
Resolves missing photo icon.
09d7a7d
@esmeace
Added Tools icon to represent Modifiers.
5283e6d
esmeace and others added 15 commits July 26, 2023 09:23
@github-actions
Copy link

lucee@be Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit a1937ea. ± Comparison against base commit 59579a9.

@github-actions
Copy link

lucee@5 Test Results

    2 files  ±0    45 suites  ±0   25s ⏱️ +6s
228 tests ±0  224 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
232 runs  ±0  224 ✔️ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a1937ea. ± Comparison against base commit 59579a9.

@github-actions
Copy link

adobe@2018 Test Results

    2 files  ±0    45 suites  ±0   22s ⏱️ -1s
228 tests ±0  224 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
232 runs  ±0  224 ✔️ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a1937ea. ± Comparison against base commit 59579a9.

@github-actions
Copy link

adobe@2023 Test Results

    2 files  ±0    45 suites  ±0   23s ⏱️ -1s
228 tests ±0  224 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
232 runs  ±0  224 ✔️ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a1937ea. ± Comparison against base commit 59579a9.

@github-actions
Copy link

adobe@2021 Test Results

    2 files  ±0    45 suites  ±0   22s ⏱️ -2s
228 tests ±0  224 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
232 runs  ±0  224 ✔️ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit a1937ea. ± Comparison against base commit 59579a9.

@esmeace esmeace requested review from lmajano and jclausen July 26, 2023 19:02
@lmajano lmajano merged commit a53aff7 into development Jul 27, 2023
1 check passed
@lmajano lmajano deleted the CONTENTBOX-1481-Missing-Icons branch July 27, 2023 09:28
@esmeace esmeace mentioned this pull request Jul 28, 2023
Merged
@esmeace esmeace removed the In Review label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmajano lmajano Awaiting requested review from lmajano

@jclausen jclausen Awaiting requested review from jclausen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esmeace @lmajano