ContentBox 1450 menu manager sandbox display is broken #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is also corrects the removal of the class 'open' when the user clicks outside the li, which is the normal dropdown behavior of Bootstrap 3.4.
…rwritten by .btn-more; therefore, it is unnecessary. The class to add margin to the dropdown menu items also became unnecessary after adjusting the dropdown's CSS.
…entBox into CONTENTBOX-1474-Enhance-Logo-Quality # Conflicts: # modules/contentbox/modules/contentbox-admin/resources/assets/sass/theme/_variables.scss
…ttps://github.com/Ortus-Solutions/ContentBox into CONTENTBOX-1476-Links-do-not-have-enough-contrast
…ttps://github.com/Ortus-Solutions/ContentBox into CONTENTBOX-1476-Links-do-not-have-enough-contrast
…ttps://github.com/Ortus-Solutions/ContentBox into CONTENTBOX-1476-Links-do-not-have-enough-contrast
…the "group" of buttons. Moving the btn-group, caused a jump on the last item, and the rounded border was removed because on hover a child element ( tooltip ) was added inside the btn-group div. To correct this, a span was inserted inside the button and the tooltip was applied to this span. Also replaced the <a> with a <button> tag, which corrects the inability to tab through the buttons.
…ed the font icons with the Icon component (svg ).
…his corrected the inability to tab to this element. Replaced the font icon with the Icon component ( svg ). Moved the button from the h1 to right above the menu.
…n here was moved to the top left and off the panel. The font icon was also replaced with the Icon compoent.
…entBox into CONTENTBOX-1450-menu-manager-sandbox-display-is-broken # Conflicts: # modules/contentbox/modules/contentbox-admin/resources/assets/sass/contentbox.scss # modules/contentbox/modules/contentbox-admin/resources/assets/sass/theme/_buttons.scss # modules/contentbox/modules/contentbox-admin/views/_components/ui/Icon.cfm
lmajano
deleted the
CONTENTBOX-1450-menu-manager-sandbox-display-is-broken
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the following: