Nhse d34 nhskv.i30 cachere #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than compiling the regex and then discarding, use the compiled regex to improve query performance. Requires some further alignment of PB and HTTP API to check the compiled regular expression before forming the query within each aPI
i.e. use validated timeout
|
Performance test shows a 3% improvement in throughput (when using the CPU-intensive HTTP-only NHS test) |
Prevents continuous re-processing of strings to extract headers
.. and use webmachine with support for looking up pre-normalised keys in request headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache compiled regular expressions used repeatedly in the API, and compile regular expressions for use in 2i queries (not just for validation)