Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nhse develop d30upd #15

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Nhse develop d30upd #15

merged 10 commits into from
Feb 13, 2024

Commits on Nov 14, 2023

  1. Merge pull request #1 from nhs-riak/nhse-contrib-kv1871 

    KV i1871 - Handle timeout on remote connection
    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a2f66b5 View commit details
    Browse the repository at this point in the history

  2. Trigger batch correctly at each size (#4)

    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0ae011a View commit details
    Browse the repository at this point in the history

  3. Force timeout to trigger (#3) 

    Previously, the inactivity timeout on handle_continue could be cancelled by a call to riak_kv_rpelrtq_snk (e.g. from riak_kv_rpelrtq_peer).  this might lead to the log_stats loop never being triggered.
    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0c5579c View commit details
    Browse the repository at this point in the history

  4. Configurable %key query on leveled (#8) 

    Can be configured to ignore tombstone keys by default.
    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5eecd92 View commit details
    Browse the repository at this point in the history

  5. Allow nextgenrepl to real-time replicate reaps (#6) 

    * Allow nextgenrepl to real-time replicate reaps

This is to address the issue of reaping across sync'd clusters.  Without this feature it is necessary to disable full-sync whilst independently replicating on each cluster.

Now if reaping via riak_kv_reaper the reap will be replicated assuming the `riak_kv.repl_reap` flag has been enabled.  At the receiving cluster the reap will not be replicated any further.

There are some API changes to support this.  The `find_tombs` aae_fold will now return Keys/Clocks and not Keys/DeleteHash.  The ReapReference for riak_kv_repaer will now expect a clock (version vector) not a DeleteHash, and will also now expect an additional boolean to indicate if this repl is a replication candidate (it will be false for all pushed reaps).

The object encoding for nextgenrepl now has a flag to indicate a reap, with a special encoding for reap references.

* Update riak_object.erl

Clarify specs

* Take timestamp at correct point (after push)

* Updates following review

* Update rebar.config
    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    5fc492e View commit details
    Browse the repository at this point in the history

  6. Make current_peers empty when disabled (#10) 

    * Make current_peers empty when disabled

* Peer discovery to recognise suspend and disable of sink

* Update src/riak_kv_replrtq_peer.erl

Co-authored-by: Thomas Arts <[email protected]>

* Update src/riak_kv_replrtq_peer.erl

Co-authored-by: Thomas Arts <[email protected]>

---------

Co-authored-by: Thomas Arts <[email protected]>
    @martinsumner @ThomasArts
    martinsumner and ThomasArts committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0b030e1 View commit details
    Browse the repository at this point in the history

  7. De-lager

    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0c1fee8 View commit details
    Browse the repository at this point in the history

  8. Add support for v0 object in parallel-mode AAE (#11) 

    * Add support for v0 object in parallel-mode AAE

Cannot assume that v0 objects will not happen - capability negotiation down to v0 on 3.0 Riak during failure scenarios

* Update following review

As ?MAGIC is distinctive constant, then it should be the one on the pattern match - with everything else assume to be convertible by term_to_binary.

* Update src/riak_object.erl

Co-authored-by: Thomas Arts <[email protected]>

---------

Co-authored-by: Thomas Arts <[email protected]>
    @martinsumner @ThomasArts
    martinsumner and ThomasArts committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    acbf337 View commit details
    Browse the repository at this point in the history

  9. Update riak_kv_ttaaefs_manager.erl (#13) 

    For bucket-based full-sync `{tree_compare, 0}` is the return on success.
    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    19b50c3 View commit details
    Browse the repository at this point in the history

  10. Correct log macro typo

    @martinsumner
    martinsumner committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    08efbe3 View commit details
    Browse the repository at this point in the history