Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: add a modal to manage waypoints in manchette #8796

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SharglutDev
Copy link
Contributor

@SharglutDev SharglutDev commented Sep 6, 2024

close #8627

Will stay in draft until #8775 is merged

A temporary "Waypoint" button has been added on top of the space time chart to test the PR
Submitting the modal won't update the manchette for now (will be done in #8628)

Warning

The shift + click doesn't work with firefox (OpenRailAssociation/osrd-ui#510)

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.27%. Comparing base (68e0513) to head (9c45b12).
Report is 1 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #8796       +/-   ##
=============================================
+ Coverage     37.13%   67.27%   +30.13%     
  Complexity     2211     2211               
=============================================
  Files          1260      662      -598     
  Lines        115076    48475    -66601     
  Branches       3230     2086     -1144     
=============================================
- Hits          42736    32612    -10124     
+ Misses        70407    15067    -55340     
+ Partials       1933      796     -1137     
Flag Coverage Δ
core 74.67% <ø> (ø)
editoast 72.56% <ø> (+<0.01%) ⬆️
front ?
gateway 2.20% <ø> (ø)
osrdyne 2.60% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/manchette/add-waypoints-modal branch 7 times, most recently from 0e7c667 to f337268 Compare September 20, 2024 09:22
@SharglutDev SharglutDev force-pushed the pfn/front/manchette/add-waypoints-modal branch from f337268 to 9c45b12 Compare September 20, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add multi-select modal for waypoints in manchette
2 participants