Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update hyperparameters #113

Merged
merged 2 commits into from
Jun 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions examples/cartpole/dqn_cartpole.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
seed: 0
lr: 7e-4
gamma: 0.9
episode_length: 1000
mini_batch_size: 64
train_interval: 10
episode_length: 2000
epsilon_anneal_time: 20000
mini_batch_size: 128
train_interval: 50
num_mini_batch: 50
run_dir: ./run_results/
experiment_name: train_dqn
log_interval: 10
log_interval: 50

use_recurrent_policy: false
use_joint_action_loss: false
Expand Down
6 changes: 3 additions & 3 deletions examples/cartpole/train_dqn_beta.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,20 @@ def train():
cfg = cfg_parser.parse_args(["--config", "dqn_cartpole.yaml"])

# 创建 环境
env = make("CartPole-v1", env_num=4)
env = make("CartPole-v1", env_num=1)
# 创建 神经网络
net = Net(env, cfg=cfg)
# 初始化训练器
agent = Agent(net)
# 开始训练
agent.train(total_time_steps=100000)
agent.train(total_time_steps=40000)
env.close()
return agent


def evaluation(agent):
# 开始测试环境
env = make("Acrobot-v1", render_mode="group_human", env_num=1, asynchronous=True)
env = make("CartPole-v1", render_mode="group_human", env_num=1, asynchronous=True)
agent.set_env(env)
obs, info = env.reset()
done = False
Expand Down
37 changes: 30 additions & 7 deletions openrl/drivers/offpolicy_driver.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@
self.epsilon_start = config["cfg"].epsilon_start
self.epsilon_finish = config["cfg"].epsilon_finish
self.epsilon_anneal_time = config["cfg"].epsilon_anneal_time
if self.envs.parallel_env_num > 1:
self.episode_steps = np.zeros((self.envs.parallel_env_num,))

Check warning on line 50 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L49-L50

Added lines #L49 - L50 were not covered by tests
else:
self.episode_steps = 0
self.verbose_flag = False
self.first_insert_buffer = True

Check warning on line 54 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L52-L54

Added lines #L52 - L54 were not covered by tests

def _inner_loop(
self,
Expand Down Expand Up @@ -96,8 +102,6 @@
dtype=np.float32,
)

# rewards[dones] = np.zeros((dones.sum(), 1), dtype=np.float32)

masks = np.ones((self.n_rollout_threads, self.num_agents, 1), dtype=np.float32)
masks[dones] = np.zeros((dones.sum(), 1), dtype=np.float32)

Expand All @@ -123,19 +127,37 @@
obs = self.buffer.data.critic_obs[0]
for step in range(self.episode_length):
q_values, actions, rnn_states = self.act(step)
# print("step: ", step,
# "state: ", self.buffer.data.get_batch_data("next_policy_obs" if step != 0 else "policy_obs", step),
# "q_values: ", q_values,
# "actions: ", actions)

extra_data = {
"q_values": q_values,
"step": step,
"buffer": self.buffer,
}

next_obs, rewards, dones, infos = self.envs.step(actions, extra_data)
if type(self.episode_steps)==int:
if not dones:
self.episode_steps += 1

Check warning on line 140 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L138-L140

Added lines #L138 - L140 were not covered by tests
else:
# print("steps: ", self.episode_steps)
self.episode_steps = 0

Check warning on line 143 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L143

Added line #L143 was not covered by tests
else:
done_index = list(np.where(dones == True)[0])
self.episode_steps += 1
for i in range(len(done_index)):
if self.episode_steps[done_index[i]] > 200:
self.verbose_flag = True

Check warning on line 149 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L145-L149

Added lines #L145 - L149 were not covered by tests
# print("steps: ", self.episode_steps[done_index[i]])
self.episode_steps[done_index[i]] = 0

Check warning on line 151 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L151

Added line #L151 was not covered by tests

# if self.verbose_flag:
# print("step: ", step,
# "state: ", self.buffer.data.get_batch_data("next_policy_obs" if step != 0 else "policy_obs", step),
# "q_values: ", q_values,
# "actions: ", actions)
# print("rewards: ", rewards)


data = (
obs,
next_obs,
Expand All @@ -151,6 +173,7 @@
obs = next_obs

batch_rew_infos = self.envs.batch_rewards(self.buffer)
self.first_insert_buffer = False

Check warning on line 176 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L176

Added line #L176 was not covered by tests

if self.envs.use_monitor:
statistics_info = self.envs.statistics(self.buffer)
Expand Down Expand Up @@ -194,7 +217,7 @@

actions = np.expand_dims(q_values.argmax(axis=-1), axis=-1)

if random.random() >= epsilon:
if random.random() >= epsilon or self.first_insert_buffer:

Check warning on line 220 in openrl/drivers/offpolicy_driver.py

View check run for this annotation

Codecov / codecov/patch

openrl/drivers/offpolicy_driver.py#L220

Added line #L220 was not covered by tests
actions = np.random.randint(
low=0, high=self.envs.action_space.n, size=actions.shape
)
Expand Down