Custom django-waffle middleware to store testing flags #1109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedankenstuecke
approved these changes
May 8, 2020
dragon-dxw
added a commit
to jazzband/django-waffle
that referenced
this pull request
May 3, 2024
Addresses #80 Uses code from OpenHumans/open-humans#1109
dragon-dxw
added a commit
to jazzband/django-waffle
that referenced
this pull request
May 3, 2024
Addresses #80 Uses code from OpenHumans/open-humans#1109
dragon-dxw
added a commit
to jazzband/django-waffle
that referenced
this pull request
May 3, 2024
Addresses #80 Uses code from OpenHumans/open-humans#1109
|
@madprime I've made that PR because I fell into the same trap. Could you chime in on jazzband/django-waffle#505 and confirm that you're happy for your code to be used in the project in this way? And possibly any problems that implementing these changes might cause? |
|
hey @dragon-dxw, at least we didn't run into any issues with it, but also have to say we didn't end up using it a whole lot on our end! Regarding using the code: I can't speak for @madprime, but would assume that yes, as our code base is MIT licensed 🙂 |
dragon-dxw
added a commit
to jazzband/django-waffle
that referenced
this pull request
Jun 4, 2024
Addresses #80 Uses code from OpenHumans/open-humans#1109
dragon-dxw
added a commit
to jazzband/django-waffle
that referenced
this pull request
Jul 3, 2024
Addresses #80 Uses code from OpenHumans/open-humans#1109
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes django-waffle testing flags "stick" when not used by an initial view or template.
django-waffle has an open issue regarding testing flags not being stored in cookie unless there's some attempt to use them in a view or template: jazzband/django-waffle#80
While the issue seems to think this isn't solvable without breaking backwards compatibility, it seems like my modification to the middleware should generally work? (It uses the flag customization that was described as an issue.)
So, this seems to work for me, but maybe I'm missing something. (And I might submit this solution as a PR to django-waffle.)
Testing