Merge pull request #176 from lalithkota/17.0-1.2

Update API: fixed update when id already exists
OpenG2P · Aug 28, 2024 · ff627e9 · ff627e9
2 parents 9a2ada9 + 958d05f
commit ff627e9
Showing 1 changed file with 7 additions and 14 deletions.
diff --git a/g2p_registry_rest_api/routers/individual.py b/g2p_registry_rest_api/routers/individual.py
@@ -170,23 +170,16 @@ async def update_individual(
                 # Update the individual
                 indv_rec = env["process_individual.rest.mixin"]._process_individual(request)
 
-                for reg_id in indv_rec["reg_ids"]:
+                for i in range(len(indv_rec.get("reg_ids", []) or [])):
+                    reg_id = indv_rec["reg_ids"][i]
                     id_type_id = reg_id[2].get("id_type")
-                    value = reg_id[2].get("value")
-
-                    id_rec = (
-                        env["g2p.reg.id"]
-                        .sudo()
-                        .search(
-                            [
-                                ("value", "=", value),
-                                ("id_type", "=", id_type_id),
-                            ],
-                            limit=1,
-                        )
+
+                    id_rec = partner_rec.reg_ids.filtered(
+                        lambda x, id_type_id=id_type_id: x.id_type.id == id_type_id
                     )
+
                     if id_rec:
-                        id_rec.unlink()
+                        indv_rec["reg_ids"][i] = (1, id_rec.id, reg_id[2])
 
                 partner_rec.write(indv_rec)
                 results.append(UpdateIndividualInfoResponse.model_validate(partner_rec))