Upgrade code quality a notch

OpenConext · Jun 24, 2024 · 873f4b0 · 873f4b0
1 parent e18f80a
commit 873f4b0
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 18 deletions.
diff --git a/src/Saml/ResponseContext.php b/src/Saml/ResponseContext.php
@@ -28,9 +28,9 @@
 final class ResponseContext implements ResponseContextInterface
 {
     public function __construct(
-        private IdentityProvider $hostedIdentityProvider,
-        private ServiceProviderRepository $serviceProviderRepository,
-        private StateHandlerInterface $stateHandler
+        private readonly IdentityProvider $hostedIdentityProvider,
+        private readonly ServiceProviderRepository $serviceProviderRepository,
+        private readonly StateHandlerInterface $stateHandler
     ) {
     }
 

diff --git a/src/Service/DateTime/StaticDateTimeService.php b/src/Service/DateTime/StaticDateTimeService.php
@@ -25,11 +25,12 @@
 final class StaticDateTimeService extends AbstractDateTimeService
 {
 
-    public function __construct(private readonly DateTimeImmutable $dateTime)
-    {
+    public function __construct(
+        private readonly DateTimeImmutable $dateTime
+    ) {
     }
 
-    public function getCurrent(): \DateTimeImmutable
+    public function getCurrent(): DateTimeImmutable
     {
         return $this->dateTime;
     }

diff --git a/src/Service/ResponseService.php b/src/Service/ResponseService.php
@@ -35,10 +35,10 @@
 final class ResponseService implements ResponseServiceInterface
 {
     public function __construct(
-        private IdentityProvider $hostedIdentityProvider,
-        private ResponseContextInterface $responseContext,
-        private AssertionSigningServiceInterface $assertionSigningService,
-        private DateTimeService $dateTimeService
+        private readonly IdentityProvider $hostedIdentityProvider,
+        private readonly ResponseContextInterface $responseContext,
+        private readonly AssertionSigningServiceInterface $assertionSigningService,
+        private readonly DateTimeService $dateTimeService
     ) {
     }
 

diff --git a/src/Service/StateBasedAuthenticationService.php b/src/Service/StateBasedAuthenticationService.php
@@ -35,9 +35,9 @@
 final class StateBasedAuthenticationService implements AuthenticationService
 {
     public function __construct(
-        private StateHandlerInterface $stateHandler,
-        private RouterInterface $router,
-        private LoggerInterface $logger
+        private readonly StateHandlerInterface $stateHandler,
+        private readonly RouterInterface $router,
+        private readonly LoggerInterface $logger
     ) {
     }
 

diff --git a/src/Service/StateBasedRegistrationService.php b/src/Service/StateBasedRegistrationService.php
@@ -34,9 +34,9 @@
 final class StateBasedRegistrationService implements RegistrationService
 {
     public function __construct(
-        private StateHandlerInterface $stateHandler,
-        private RouterInterface $router,
-        private LoggerInterface $logger
+        private readonly StateHandlerInterface $stateHandler,
+        private readonly RouterInterface $router,
+        private readonly LoggerInterface $logger
     ) {
     }
 

diff --git a/src/Service/StateHandler.php b/src/Service/StateHandler.php
@@ -25,8 +25,6 @@
 use Surfnet\SamlBundle\SAML2\Extensions\GsspUserAttributesChunk;
 use Surfnet\SamlBundle\SAML2\ReceivedAuthnRequest;
 use TypeError;
-use function is_string;
-use function sprintf;
 
 /**
  * Knows and preserves the integrity of the GSSP application state.