Feat withdrawl queue #160
Merged
Feat withdrawl queue #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
started some prelim tests
- withdraw_stashed_liquidity -> claim_queued_liquidity - lp_stashes: (bool, u256) -> u256
added amount so that the user can select the portion they want stashed once the round settles, and can overwrite if they want to update this value
- re-order functions in impl - updated queueing to take in the an amount param - re-defined/re-factored internal helper functions - simplified external functions
- assert if a == b +- range
rm divide with precision rm old comments re order logic
get_lp_queued_balance & get_total_queued_balance now accept round_ids
for withdraw_queued & claim_queued_liquidity
reserve price, cap level, & volatility are now stored by round instead of time range TWAP is still time range
added tests as well
refined logic for setting default values for mock market aggregator created function to deploy vault facades with a custom VaultType
- update connection to mk agg - broke apart deploying first round vs next round (for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
queue_withdrawal()&collect_queued_liquidity()entry pointsVault::Event::WithdrawalQueued&Vault::Event::QueuedLiquidityCollectedget_lp_queued_balance(liquidity_provider)&get_total_queued_balance(round_id)get_lp_queued_balance(),get_lp_stashed_balance()&get_total_stashed_balance()Vault::get_current_option_round_id()becameVault::get_current_round_id()Vault::get_option_round_address()becameVault::get_round_address()OptionRound::get_refundable_bids_for()becameOptionRound::get_refundable_balance_for().OptionRound::get_tokenizable_options_for()becameOptionRound::get_mintable_options_for().OptionRound::tokenize_options()becameOptionRound::mint_options().OptionRound::Event::OptionsTokenizedbecameOptionRound::Event::OptionsMintedVault::get_unsold_liquidity(round_id)becameOptionRound::unsold_liquidity()