Feat/sim details #158
Merged
Feat/sim details #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruv035
changed the base branch from
develop
to
chore/update-entrypoint-names
dhruv035
added a commit
that referenced
this pull request
Sep 16, 2024
* commented out LP token tests * updated vault interface naming * added settlement price getter to option round * formatting * formatting * added tests for vault queued bps * clean comments, sorting, variable/function names * Update red_black_tree.cairo reduced some logic to use less steps updated storage var names for clarity * update vault contract -removed vault_manager -updated calls to new round interface -changed event to StashWithdrawn (instead of QueuedLiquidityCollected) * update bid struct -fixed member names for clarity * update option round contract - change update bid to taking in price increase, amount cannot be altered now - update account bid nonce to u64 to match tree nonce - made auction start event also emit starting liquidity - changed bid accepted event to bid placed event - bid update event emits price increase - made auction end event also emit unsold liquidity - dropped total payout from round settled event - * formatting * updated comments and sorting of functions * updated comments also store vault's and accounts' queued liquidity in the same mapping * remove old comments * update storage var * Feat/sim details (#158) * Edits * Remove Outputs * Update gitignore * Update withdrawal premiums logic * Fuzzing * Update tests --------- Co-authored-by: Dhruv Gupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.