feat: support google cloud storage as das #2643
Conversation
cla-bot
bot
added
the
s
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
283d2c9
to
67a03db
Compare
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
5f6ede4
to
2ae64de
Compare
|
Proof of working: |
renlulu
force-pushed
the
feat/das-google-cloud
branch
2 times, most recently
from
a9aee5f
to
0750428
Compare
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
0750428
to
2209476
Compare
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
8fcdad9
to
67c377d
Compare
| type GoogleCloudStorageConfig struct { | ||
| AccessToken string `koanf:"access-token"` |
There was a problem hiding this comment.
The pattern for the other storage backend types is to have an Enable bool field, defaulting to false.
There was a problem hiding this comment.
Actually it looks like you've got duplicated structs that do almost the same thing. GoogleCloudStorageServiceConfig is the other one.
There was a problem hiding this comment.
Sorry but the is one for unit tests only? also defaultStorageRetention not exported from das, so cannot use it here(genericconf)
There was a problem hiding this comment.
I was referring the s3 part, so GoogleCloudStorageConfig for ut, GoogleCloudStorageServiceConfig is for actual usage, hope i didn't get it wrongly : D
There was a problem hiding this comment.
while GoogleCloudStorageServiceConfig follow the same pattern
type GoogleCloudStorageServiceConfig struct {
Enable bool `koanf:"enable"`
AccessToken string `koanf:"access-token"`
Bucket string `koanf:"bucket"`
ObjectPrefix string `koanf:"object-prefix"`
EnableExpiry bool `koanf:"enable-expiry"`
MaxRetention time.Duration `koanf:"max-retention"`
}
261a80f
to
98d42fa
Compare
renlulu
force-pushed
the
feat/das-google-cloud
branch
from
98d42fa
to
65b2165
Compare
|
@Tristan-Wilson Hey can we follow up here? |
No description provided.