Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mqttchambertemperature #1267

Merged
merged 1 commit into from
Jan 2, 2024
Merged

add mqttchambertemperature #1267

merged 1 commit into from
Jan 2, 2024

Conversation

synman
Copy link
Contributor

@synman synman commented Jan 2, 2024

this plugin enables chamber temperature reporting using an mqtt topic subscription

@jneilliii
Copy link
Contributor

Not sure if you just missed this, but here you can use self._settings.get_int(["convertFromFahrenheit"])

jneilliii
jneilliii requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@jneilliii jneilliii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We prefer to have registered plugins have a software update hook, and it appears your plugin is missing this.

@synman
Copy link
Contributor Author

synman commented Jan 2, 2024 •
edited
Loading

completely forgot to implement the version management block. Thanks for the full PR review.

update hook: https://github.com/synman/OctoPrint-MqttChamberTemperature/blob/0.0.1/octoprint_mqttchambertemperature/__init__.py#L132

convertFromFahrenheit should be boolean (doh): https://github.com/synman/OctoPrint-MqttChamberTemperature/blob/0.0.1/octoprint_mqttchambertemperature/__init__.py#L44

@synman synman requested a review from jneilliii January 2, 2024 20:53
@jneilliii jneilliii merged commit 0c4b743 into OctoPrint:gh-pages Jan 2, 2024
5 checks passed
@synman synman deleted the OctoPrint-MQTTChamberTemperature branch January 2, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jneilliii jneilliii jneilliii approved these changes

Assignees
No one assigned
Labels
needs work
Projects
OctoPrint Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@synman @jneilliii