New Plugin "Wattometer"

[RealTryZ]

No description provided.

[jneilliii]

Is your plugin repo private? I'm getting a 404 when attempting to review your plugin.

[RealTryZ]

It was sorry for the mistake jneilliii ***@***.***> schrieb am Mi., 19. Juli 2023, 20:14:

…

Is your plugin repo private? I'm getting a 404 when attempting to review your plugin. — Reply to this email directly, view it on GitHub <#1216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AWWTU4KTFGWFFJ6UZ2HU2NDXRAPYLANCNFSM6AAAAAA2QIY34M> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jneilliii]

besides the one small typo, your plugin needs this line updated to include the fritzconnection module dependency so it automatically gets installed.

plugin_requires = ["fritzconnection"]

It's frowned upon slightly to use CDN for your js files. It's better to bundle them within your plugin in static/js folder and then include it in your get_assets callback. You can see an example of how this is achieved with Bed Level Visualizer here.

once that gets updated create a 0.1.0 release on GitHub.

[jneilliii]

Sorry I missed it before @RealTryZ, but it would be best if you also had a software update hook in your plugin, so that if you end up having to release new versions your users will get automatically notified of the new update as you make new releases. You can find the docs for that here, with a simple example. Make sure to use Wattometer identifier in place of updateplugindemo in that example.

[RealTryZ]

Sorry I missed it before @RealTryZ, but it would be best if you also had a software update hook in your plugin, so that if you end up having to release new versions your users will get automatically notified of the new update as you make new releases. You can find the docs for that here, with a simple example. Make sure to use Wattometer identifier in place of updateplugindemo in that example.

Thanks for the tip, I fixed it now and included that hook.

[jneilliii]

You missed the bit about changing the identifier in the return here. Change updateplugindemo to Wattometer to match your plugin identifier.

[RealTryZ]

You missed the bit about changing the identifier in the return here. Change updateplugindemo to Wattometer to match your plugin identifier.

I'm really sorry, fixed it now. Thanks for your patience