Deprecate [MASWE-0013] and add [MASTG-TEST-0210] and [MASTG-DEMO-0015] Hardcoded Cryptographic Keys in Code (by appknox) #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpholguera
requested changes
Aug 30, 2024
cpholguera
changed the title
cpholguera
requested changes
Aug 30, 2024
There was a problem hiding this comment.
TODO update the output after running the new rule on MastgTest_reversed.java
| @@ -0,0 +1 @@ | |||
| semgrep -c ../rules/mastg-android-hardcoded-crypto-keys-usage.yml ./hardcoded-key-in-use.java --text -o output.txt | |||
There was a problem hiding this comment.
This must work on MastgTest_reversed.java
Suggested change
| semgrep -c ../rules/mastg-android-hardcoded-crypto-keys-usage.yml ./hardcoded-key-in-use.java --text -o output.txt | |
| semgrep -c ../rules/mastg-android-hardcoded-crypto-keys-usage.yml ./MastgTest_reversed.java --text -o output.txt |
|
We have started working on this, soon we will send the next PR. |
|
@cpholguera We have added the Android section of the test case. Please review it, thank you. |
cpholguera
requested changes
Sep 3, 2024
There was a problem hiding this comment.
@ScreaMy7 I think we can merge after integrating these last changes. Please read thought them and use the "Add suggestion to batch" and "Commit Suggestions" functions to integrate the changes.
added the changes Co-authored-by: Carlos Holguera <[email protected]>
cpholguera
approved these changes
Sep 3, 2024
cpholguera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2577