Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MASWE-0019] Potentially Weak Cryptography Implementations #2863

Merged
merged 12 commits into from
Sep 4, 2024
Merged

[MASWE-0019] Potentially Weak Cryptography Implementations #2863

merged 12 commits into from
Sep 4, 2024

Conversation

jmariasantosdekra
Copy link
Collaborator

This PR closes #2583

@jmariasantosdekra
Copy link
Collaborator Author

Hi @cpholguera, I have submitted the PR, but fails in a check. The issue is an extra blank space before Mitigations. Do I need to reupload the PR? Thanks

@cpholguera
Copy link
Collaborator

@jmariasantosdekra you don't need to reopen the PR. Simply delete the blank lines as indicated: [Expected: 1; Actual: 2]; commit the changes and push

@cpholguera
Copy link
Collaborator

Thanks a lot! That fixed the issues, we'll review soon!

cpholguera
cpholguera requested changes Aug 12, 2024
View reviewed changes
weaknesses/MASVS-CRYPTO/MASWE-0019.md Outdated Show resolved Hide resolved
weaknesses/MASVS-CRYPTO/MASWE-0019.md Outdated Show resolved Hide resolved
jmariasantosdekra and others added 8 commits September 4, 2024 08:11
cpholguera
cpholguera approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jmariasantosdekra!

@cpholguera cpholguera merged commit a83f71b into OWASP:master Sep 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpholguera cpholguera cpholguera approved these changes

@TheDauntless TheDauntless Awaiting requested review from TheDauntless

Assignees

@jmariasantosdekra jmariasantosdekra

Labels
MASVS-CRYPTO MASWE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MASWE-0019] Potentially Weak Cryptography Implementations
2 participants
@jmariasantosdekra @cpholguera