Skip to content

Commit

Permalink
Apply grammar fixes from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jeroen Beckers <[email protected]>
  • Loading branch information
cpholguera and TheDauntless authored Aug 23, 2024
1 parent 3f500f2 commit 1761e35
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion weaknesses/MASVS-PRIVACY/MASWE-0109.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Sensitive data might be used for secondary purposes or beyond the initial scope
This risk can be introduced in various scenarios, including:

- Use of user data collected for secondary purpose without user consent or control.
- Continuous access to user data without user controls.
- Continuous access to user data without user control.


Check failure on line 24 in weaknesses/MASVS-PRIVACY/MASWE-0109.md

View workflow job for this annotation

GitHub Actions / markdown-lint-check

Multiple consecutive blank lines

weaknesses/MASVS-PRIVACY/MASWE-0109.md:24 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md012.md
## Impact
Expand Down
2 changes: 1 addition & 1 deletion weaknesses/MASVS-PRIVACY/MASWE-0110.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Technical barriers need to be established when utilizing complex ‘finger-print
This risk can be introduced in various scenarios, including:

- Unnecessary collection of identifiers like device IDs, IP addresses, behavioral patterns that can lead to user identification and tracking.
- No anonymization and Pseudonymisation measures to strip data of any direct identifiers such as user ID or name before server side collection.
- No anonymization and pseudonymisation measures to strip data of any direct identifiers such as user ID or name before server side collection.
- Reusing signals collected for a specific purpose for other features (e.g fingerprinting for fraud detection).


Check failure on line 28 in weaknesses/MASVS-PRIVACY/MASWE-0110.md

View workflow job for this annotation

GitHub Actions / markdown-lint-check

Multiple consecutive blank lines

weaknesses/MASVS-PRIVACY/MASWE-0110.md:28 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md012.md
Expand Down
2 changes: 1 addition & 1 deletion weaknesses/MASVS-PRIVACY/MASWE-0111.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ The risk here is data being collected and shared without user awareness (therefo
This risk can be introduced in various scenarios, including:

- Sensor data or local data is collected without explicit user consent.
- Though consent is present the user is not adequately informed about how the data is used or shared (like between apps and 3rd party SDKs).
- Though consent is present the user is not adequately informed about how the data is used or shared (e.g. between the app and third-party SDKs).
- Discrepancy between store declarations, privacy policy and actual behavior.


Check failure on line 29 in weaknesses/MASVS-PRIVACY/MASWE-0111.md

View workflow job for this annotation

GitHub Actions / markdown-lint-check

Multiple consecutive blank lines

weaknesses/MASVS-PRIVACY/MASWE-0111.md:29 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md012.md
Expand Down
4 changes: 2 additions & 2 deletions weaknesses/MASVS-PRIVACY/MASWE-0112.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ status: new

## Overview

Offer users control over their data refers to giving the user the option of managing, deleting, modifying and revoking consent to their data. Including re prompting for consent when requesting more data than initially specified.
Offering users control over their data refers to giving the user the option of managing, deleting, modifying and revoking access to their data. Including obtaining additional consent when requesting more data than initially specified.

The risk here is the user not having control of their data once collected. To mitigate this risk, users should be provided the option to request deletion of collected data, revoke consent and allow users to modify privacy settings with granularity.
The risk here is the user not having control of their data once collected. To mitigate this risk, users should have the option to request deletion of collected data and revoke consent. Additionally, users should be able to modify their privacy settings with granularity.


Check failure on line 20 in weaknesses/MASVS-PRIVACY/MASWE-0112.md

View workflow job for this annotation

GitHub Actions / markdown-lint-check

Multiple consecutive blank lines

weaknesses/MASVS-PRIVACY/MASWE-0112.md:20 MD012/no-multiple-blanks Multiple consecutive blank lines [Expected: 1; Actual: 2] https://github.com/DavidAnson/markdownlint/blob/v0.34.0/doc/md012.md
## Modes of Introduction
Expand Down
4 changes: 2 additions & 2 deletions weaknesses/MASVS-PRIVACY/MASWE-0113.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ status: new
## Overview
Consent should be freely given, specific, informed and unambiguous.

The risk here is to bundle consent with the terms of services or the data processing outside of the original consent scope.
The risk here is to bundle consent with the terms of services or the processing of data outside of the original consent scope.


## Modes of Introduction

This risk can be introduced in various scenarios, including:

- Consent is bundled with the terms of services. For example, the consent language says ‘ by using this service, you agree to provide your data for research purposes.’
- Consent covers the future use cases. For example, consent to pair one devices automatically applies to new devices in the future and no additional consent is obtained.
- Consent covers future use cases. For example, consent to pair one device automatically applies to new devices in the future and no additional consent is obtained.



Expand Down

0 comments on commit 1761e35

Please sign in to comment.