Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: regulator: register to dt_driver #6329

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

etienne-lms
Copy link
Contributor

Adds regulator_dt_register() for regulator drivers to register regulator instances based on the DT description of the platform.

Copy link
Contributor

@GseoC GseoC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With comment(s) adressed:
Acked-by: Gatien Chevallier <[email protected]>

core/drivers/regulator/regulator_dt.c Show resolved Hide resolved
core/include/drivers/regulator.h Show resolved Hide resolved
@etienne-lms
Copy link
Contributor Author

@GseoC, thanks for the review. I have not address #6329 (comment). May I still apply your review tag?

@GseoC
Copy link
Contributor

GseoC commented Oct 3, 2023

Yes, sure, it's only a minor comment 😊

@etienne-lms
Copy link
Contributor Author

tag applied. thanks.

Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • For "core: dt_driver: define DT_DRIVER_REGULATOR" and "core: dt_driver: add dt_driver_provider_priv_data()":
    Acked-by: Jerome Forissier <[email protected]>
  • For the third commit, please see comments below, then:
    Acked-by: Jerome Forissier <[email protected]>

core/drivers/regulator/regulator_dt.c Outdated Show resolved Hide resolved
core/drivers/regulator/regulator_dt.c Outdated Show resolved Hide resolved
Adds DT_DRIVER_REGULATOR for a regulator consumer to retrieve its
regulator device(s) from device tree information.

Acked-by: Gatien Chevallier <[email protected]>
Acked-by: Jerome Forissier <[email protected]>
Signed-off-by: Etienne Carriere <[email protected]>
Implements dt_driver_provider_priv_data() to get the private data
registered with a provider. Regulator framework will use this
function to return the regulator handle associated to a regulator
provider driver.

Acked-by: Gatien Chevallier <[email protected]>
Acked-by: Jerome Forissier <[email protected]>
Signed-off-by: Etienne Carriere <[email protected]>
Copy link
Contributor

@jforissier jforissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acked-by: Jerome Forissier <[email protected]>

Adds regulator_dt_register() for regulator drivers to register
regulator instances based on the DT description of the platform.

Regulator instances may not be created and initialized when
regulator_dt_register() returns. When a regulator depends on a
supply this latter may not yet be registered and initialized.
The framework will resolve the regulator dependencies later.

At OP-TEE core last initcall stage, a debug message informs
in case of remaining unresolved regulator dependency. Used resources
are released and no error status is returns to the system.

regulator_dt_register() uses a dedicated struct regu_dt_desc
ABI to get the description of the regulator to be registered.

Acked-by: Gatien Chevallier <[email protected]>
Acked-by: Jerome Forissier <[email protected]>
Co-developed-by: Pascal Paillet <[email protected]>
Signed-off-by: Pascal Paillet <[email protected]>
Signed-off-by: Etienne Carriere <[email protected]>
@etienne-lms
Copy link
Contributor Author

Squashed and applied review tags.

@jforissier
Copy link
Contributor

jforissier commented Oct 4, 2023

From the Xen CI log:
~~ 2023-10-04T10:20:29.6168425Z ERROR: yajl-2.1.0.tar.gz has wrong sha256 hash: 2023-10-04T10:20:29.6168839Z ERROR: expected: 3fb73364a5a30efe615046d07e6db9d09fd2b41c763c5f7d3bfb121cd5c5ac5a 2023-10-04T10:20:29.6169264Z ERROR: got : e468fa3223a9ade3eefb1018a545ce79ae302f03f98c6f3cdbfaf771e5a39ce0 2023-10-04T10:20:29.6169725Z ERROR: Incomplete download, or man-in-the-middle (MITM) attack ~~
This may be the cause of the many errors we've had recently (although I am pretty sure I have seen "No space left on device" errors too...). I'm on it.

Not a fatal error, the file is downloaded afterwards.

@jforissier jforissier merged commit 6558b56 into OP-TEE:master Oct 4, 2023
7 of 8 checks passed
@etienne-lms etienne-lms deleted the regulator-1 branch October 4, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants