-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers: regulator: register to dt_driver #6329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With comment(s) adressed:
Acked-by: Gatien Chevallier <[email protected]>
@GseoC, thanks for the review. I have not address #6329 (comment). May I still apply your review tag? |
Yes, sure, it's only a minor comment 😊 |
5300a08
to
048c2c3
Compare
tag applied. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For "core: dt_driver: define DT_DRIVER_REGULATOR" and "core: dt_driver: add dt_driver_provider_priv_data()":
Acked-by: Jerome Forissier <[email protected]>
- For the third commit, please see comments below, then:
Acked-by: Jerome Forissier <[email protected]>
Adds DT_DRIVER_REGULATOR for a regulator consumer to retrieve its regulator device(s) from device tree information. Acked-by: Gatien Chevallier <[email protected]> Acked-by: Jerome Forissier <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
Implements dt_driver_provider_priv_data() to get the private data registered with a provider. Regulator framework will use this function to return the regulator handle associated to a regulator provider driver. Acked-by: Gatien Chevallier <[email protected]> Acked-by: Jerome Forissier <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
048c2c3
to
12afd2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acked-by: Jerome Forissier <[email protected]>
Adds regulator_dt_register() for regulator drivers to register regulator instances based on the DT description of the platform. Regulator instances may not be created and initialized when regulator_dt_register() returns. When a regulator depends on a supply this latter may not yet be registered and initialized. The framework will resolve the regulator dependencies later. At OP-TEE core last initcall stage, a debug message informs in case of remaining unresolved regulator dependency. Used resources are released and no error status is returns to the system. regulator_dt_register() uses a dedicated struct regu_dt_desc ABI to get the description of the regulator to be registered. Acked-by: Gatien Chevallier <[email protected]> Acked-by: Jerome Forissier <[email protected]> Co-developed-by: Pascal Paillet <[email protected]> Signed-off-by: Pascal Paillet <[email protected]> Signed-off-by: Etienne Carriere <[email protected]>
12afd2a
to
ad99a03
Compare
Squashed and applied review tags. |
Not a fatal error, the file is downloaded afterwards. |
Adds
regulator_dt_register()
for regulator drivers to register regulator instances based on the DT description of the platform.