-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add profile types filtering to new map #3841
feat: add profile types filtering to new map #3841
Conversation
@davehakkens Early view for you of the basic interaction. |
Visit the preview URL for this PR (updated for commit e229f5d): https://onearmy-next--pr3841-feat-new-map-add-pro-rydgiwhx.web.app (expires Sun, 06 Oct 2024 15:30:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59 |
onearmy-community-platform Run #6224
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/3841
|
Run status |
Passed #6224
|
Run duration | 04m 24s |
Commit |
e229f5da38: feat: add profile types filtering to new map
|
Committer | Ben Furber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
60
|
View all changes introduced in this branch ↗︎ |
Cool!
|
@davehakkens I just used the existing filter set hense the issues with 1 and 2. Totally agree about 3. |
52b99e9
to
5c08618
Compare
5c08618
to
9ee4270
Compare
Works nice. Or is filter only for list view? Also: @dalibormrska something to review :) |
9ee4270
to
e0ddd9b
Compare
e0ddd9b
to
3918256
Compare
3918256
to
e229f5d
Compare
🎉 This PR is included in version 1.216.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No filtering on the new map.
What is the new behavior?
Adds basic filtering by profile type to the new map.