Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profile types filtering to new map #3841

Merged

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented Sep 4, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Feature (adds functionality)

What is the current behavior?

No filtering on the new map.

What is the new behavior?

Adds basic filtering by profile type to the new map.

Screenshot 2024-09-05 at 13 47 08

@benfurber benfurber added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label Sep 4, 2024
@benfurber
Copy link
Member Author

@davehakkens Early view for you of the basic interaction.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Visit the preview URL for this PR (updated for commit e229f5d):

https://onearmy-next--pr3841-feat-new-map-add-pro-rydgiwhx.web.app

(expires Sun, 06 Oct 2024 15:30:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59

Copy link

cypress bot commented Sep 4, 2024

onearmy-community-platform    Run #6224

Run Properties:  status check passed Passed #6224  •  git commit e229f5da38: feat: add profile types filtering to new map
Project onearmy-community-platform
Branch Review pull/3841
Run status status check passed Passed #6224
Run duration 04m 24s
Commit git commit e229f5da38: feat: add profile types filtering to new map
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 60
View all changes introduced in this branch ↗︎

@davehakkens
Copy link
Contributor

davehakkens commented Sep 4, 2024

Cool!
Few things

  1. Would we still merge workspaces together and replace the specific types (extrusion, shredder) for a label?
  2. Verified + Want to get started + machine shop doesnt seem to filter. (0 results)
  3. If you search 'shredder" you also see a "want to start" and "community point". I think this is data problem created when people toggle between different types or deleting their accounts but not updating map data. Seems like this might need a cleanup? (as the inaccuracy gets more visible now)

@benfurber
Copy link
Member Author

@davehakkens I just used the existing filter set hense the issues with 1 and 2.

Totally agree about 3.

@benfurber benfurber force-pushed the feat/new-map/add-profile-type-filtering branch 4 times, most recently from 52b99e9 to 5c08618 Compare September 5, 2024 12:56
@benfurber benfurber marked this pull request as ready for review September 5, 2024 12:58
@benfurber benfurber requested a review from a team as a code owner September 5, 2024 12:58
@benfurber benfurber force-pushed the feat/new-map/add-profile-type-filtering branch from 5c08618 to 9ee4270 Compare September 5, 2024 13:05
@davehakkens
Copy link
Contributor

davehakkens commented Sep 5, 2024

Works nice.
Curious: Would (perhaps later on) the filter also effect the pins on the map?
If I select machine builders > I only see machine builders in both filter and map.

Or is filter only for list view?

Also: @dalibormrska something to review :)

@benfurber benfurber force-pushed the feat/new-map/add-profile-type-filtering branch from 9ee4270 to e0ddd9b Compare September 6, 2024 09:26
@benfurber benfurber mentioned this pull request Sep 6, 2024
3 tasks
@benfurber benfurber force-pushed the feat/new-map/add-profile-type-filtering branch from e0ddd9b to 3918256 Compare September 6, 2024 12:31
@benfurber benfurber force-pushed the feat/new-map/add-profile-type-filtering branch from 3918256 to e229f5d Compare September 6, 2024 12:33
@benfurber benfurber merged commit 590f9e3 into ONEARMY:master Sep 6, 2024
21 checks passed
@benfurber benfurber deleted the feat/new-map/add-profile-type-filtering branch September 6, 2024 12:50
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.216.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Maps 🗺 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants