Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show clearly when research update is draft #3838

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Feature (adds functionality)

What is the current behavior?

It wasn't clear sometimes to research creators that there updates had been saved as drafts.

What is the new behavior?

  1. Clearly shows an update is draft on display page.
  2. Re-order the buttons that that it's a little harder to accidently set an update back to draft.
Screenshot 2024-09-03 at 13 54 34 Screenshot 2024-09-03 at 14 25 47

Copy link

cypress bot commented Sep 3, 2024

onearmy-community-platform    Run #6205

Run Properties:  status check passed Passed #6205  •  git commit 6a76e89ed6: feat: show clear when research update is draft
Project onearmy-community-platform
Branch Review pull/3838
Run status status check passed Passed #6205
Run duration 12m 05s
Commit git commit 6a76e89ed6: feat: show clear when research update is draft
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 60
View all changes introduced in this branch ↗︎

@benfurber benfurber force-pushed the feat/research/show-update-drafts-to-creator branch from c67ca12 to 5d63e64 Compare September 3, 2024 14:33
@benfurber benfurber force-pushed the feat/research/show-update-drafts-to-creator branch from 5d63e64 to 6a76e89 Compare September 3, 2024 15:18
@@ -62,164 +64,190 @@ const ResearchUpdate = (props: IProps) => {
}

const displayNumber = updateIndex + 1
const isDraft = status == 'draft'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better use ===

@benfurber benfurber merged commit 4ce7c9d into ONEARMY:master Sep 4, 2024
20 checks passed
@benfurber benfurber deleted the feat/research/show-update-drafts-to-creator branch September 4, 2024 09:09
@benfurber benfurber mentioned this pull request Sep 4, 2024
3 tasks
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.215.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants