-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show clearly when research update is draft #3838
Merged
benfurber
merged 1 commit into
ONEARMY:master
from
benfurber:feat/research/show-update-drafts-to-creator
Sep 4, 2024
Merged
feat: show clearly when research update is draft #3838
benfurber
merged 1 commit into
ONEARMY:master
from
benfurber:feat/research/show-update-drafts-to-creator
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onearmy-community-platform Run #6205
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/3838
|
Run status |
Passed #6205
|
Run duration | 12m 05s |
Commit |
6a76e89ed6: feat: show clear when research update is draft
|
Committer | Ben Furber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
0
|
Skipped |
0
|
Passing |
60
|
View all changes introduced in this branch ↗︎ |
benfurber
force-pushed
the
feat/research/show-update-drafts-to-creator
branch
from
September 3, 2024 14:33
c67ca12
to
5d63e64
Compare
benfurber
force-pushed
the
feat/research/show-update-drafts-to-creator
branch
from
September 3, 2024 15:18
5d63e64
to
6a76e89
Compare
mariojsnunes
reviewed
Sep 3, 2024
@@ -62,164 +64,190 @@ const ResearchUpdate = (props: IProps) => { | |||
} | |||
|
|||
const displayNumber = updateIndex + 1 | |||
const isDraft = status == 'draft' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use ===
mariojsnunes
approved these changes
Sep 3, 2024
3 tasks
🎉 This PR is included in version 1.215.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
It wasn't clear sometimes to research creators that there updates had been saved as drafts.
What is the new behavior?