feat: use cdn images for map pin calls #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
added
the
Review allow-preview ✅
|
(Not sure if this will be noticable on the preview branch or not.) |
benfurber
force-pushed
the
feat/new-map/optimised-images-for-list-view
branch
from
a06033c
to
0f6a3d2
Compare
|
Visit the preview URL for this PR (updated for commit 0f6a3d2): https://onearmy-next--pr3837-feat-new-map-optimis-1h933xkg.web.app (expires Thu, 03 Oct 2024 14:43:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59 |
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/3837
|
| Run status |
|
| Run duration | 04m 22s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
65
|
| View all changes introduced in this branch ↗︎ | |
|
Nope. Doesn't seem set up on preview. I'll give it until tomorrow lunch for code comments before merging in. |
|
🎉 This PR is included in version 1.214.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Slow loading on prod of the workspace cover images for the map pin list.
What is the new behavior?
Using the CDN smaller versions of the images should speed things up.