feat: update page titles #3623
Merged
feat: update page titles #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
2 flaky tests on run #5797 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| [Research] > [Create research article] > [By Authenticated] |
Test Replay
Screenshots
Video
|
|
howto/read.spec.ts • 1 flaky test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| ... > [See all info] |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #3623 ↗︎
benfurber
force-pushed
the
feat/page-titles
branch
3 times, most recently
from
86c3b6b
to
08fbb0c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3623 +/- ##
==========================================
- Coverage 74.87% 68.41% -6.47%
==========================================
Files 39 449 +410
Lines 1214 14012 +12798
Branches 247 2502 +2255
==========================================
+ Hits 909 9586 +8677
- Misses 285 4384 +4099
- Partials 20 42 +22 ☔ View full report in Codecov by Sentry. |
|
@davehakkens I don't think this is a controversial change but can you eyeball it please and shout if you have any questions. I strongly argue for it with a product manager hat on but obvs don't want you in the dark. |
davehakkens
approved these changes
Jun 13, 2024
benfurber
force-pushed
the
feat/page-titles
branch
2 times, most recently
from
064c8bf
to
53ed80d
Compare
benfurber
force-pushed
the
feat/page-titles
branch
from
53ed80d
to
31c078c
Compare
|
🎉 This PR is included in version 1.190.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Description
By not doing this before we've probably been missing out on traffic...
From --> To
Research --> Research - [Community Name]
[Research Title] --> [Research Title] - Research - [Community Name]
How-tos --> How-tos - [Community Name]
[How-to Title] --> [How-to Title] - How-to - [Community Name]
Questions --> Questions - [Community Name]
[Question Title] --> [Question Title] - Question - [Community Name]
Profile --> [Username] - Profile - [Community Name]
Plus this sets social tags of questions correctly.
Git Issues
Closes #3409