Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add guidelines component #3616

Merged
merged 5 commits into from
Jun 13, 2024

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented May 31, 2024

PR Checklist

PR Type

  • New feature (non-breaking change which adds functionality)
  • Developer experience (improves developer workflows for contributing to the project)

Description

While adding a step to the question guidelines I used it as a chance to move some styling into the component library.

Git Issues

Closes #3590

Screenshots/Videos

Screenshot 2024-06-05 at 16 23 09

Copy link

cypress bot commented May 31, 2024

Passing run #5787 ↗︎

0 76 1 0 Flakiness 0

Details:

test: set test time out to 15 seconds
Project: onearmy-community-platform Commit: 4a35430c5b
Status: Passed Duration: 05:01 💡
Started: Jun 13, 2024 2:27 PM Ended: Jun 13, 2024 2:33 PM

Review all test suite changes for PR #3616 ↗︎

@davehakkens davehakkens added the Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview label May 31, 2024
Copy link
Contributor

github-actions bot commented May 31, 2024

Visit the preview URL for this PR (updated for commit 4a35430):

https://onearmy-next--pr3616-feat-add-guidelines-mx73b87v.web.app

(expires Sat, 13 Jul 2024 16:28:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59

@benfurber benfurber force-pushed the feat/add-guidelines-component branch 2 times, most recently from 283026a to 5edb7a3 Compare June 5, 2024 15:22
@benfurber benfurber force-pushed the feat/add-guidelines-component branch 4 times, most recently from bdd7780 to 06ab2be Compare June 13, 2024 14:05
@benfurber benfurber force-pushed the feat/add-guidelines-component branch from 06ab2be to 4a35430 Compare June 13, 2024 14:18
@benfurber benfurber merged commit 5ee5f51 into ONEARMY:master Jun 13, 2024
21 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.189.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: HowTo 📰 Mod: Research 🔬 released Review allow-preview ✅ Has received manual check for malicious code and can be safely built for preview
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add guidelines URL to Question creation page
4 participants