Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/add easy way to test webhooks #3610

Merged

Conversation

pizzaisdavid
Copy link
Collaborator

@pizzaisdavid pizzaisdavid commented May 29, 2024

PR Checklist

PR Type

  • chore

Description

This depends on #3598, it probably isn't worth looking at this pull request until that is merged and this is rebased.

Introduces an easy way to test webhooks.

A webhook request is made when an how-to is changed to accepted. You can see it in action in the gif below.

This pull request adds a basic nodejs server to the docker-compose and is started when using the emulator. So we can simulate sending webhooks. These changes only affect when the functions are being ran in the emulator.

webhoook

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (8a877cd) to head (9d0045c).

Current head 9d0045c differs from pull request most recent head 9df5c5a

Please upload reports for the commit 9df5c5a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3610      +/-   ##
==========================================
- Coverage   74.23%   67.76%   -6.48%     
==========================================
  Files          41      410     +369     
  Lines        1246    12693   +11447     
  Branches      250     2238    +1988     
==========================================
+ Hits          925     8601    +7676     
- Misses        300     4069    +3769     
- Partials       21       23       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pizzaisdavid pizzaisdavid mentioned this pull request Jun 3, 2024
2 tasks
@pizzaisdavid pizzaisdavid marked this pull request as draft June 9, 2024 02:05
@pizzaisdavid pizzaisdavid force-pushed the chore/add-easy-way-to-test-webhooks branch from 34eff6c to 729b602 Compare June 13, 2024 18:08
@pizzaisdavid pizzaisdavid force-pushed the chore/add-easy-way-to-test-webhooks branch from 729b602 to c076c37 Compare June 13, 2024 18:23
@pizzaisdavid pizzaisdavid marked this pull request as ready for review June 13, 2024 19:07
@pizzaisdavid pizzaisdavid force-pushed the chore/add-easy-way-to-test-webhooks branch from 67ca993 to 9df5c5a Compare June 13, 2024 19:07
@benfurber benfurber merged commit 460b1ce into ONEARMY:master Jun 14, 2024
11 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.190.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pizzaisdavid pizzaisdavid deleted the chore/add-easy-way-to-test-webhooks branch June 14, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants