Added requested changes

ONEARMY · Apr 30, 2024 · f5d7083 · f5d7083
1 parent cf2c766
commit f5d7083
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 9 deletions.
diff --git a/packages/cypress/src/integration/questions/read.spec.ts b/packages/cypress/src/integration/questions/read.spec.ts
@@ -32,7 +32,7 @@ describe('[Questions]', () => {
 
       cy.step('Can visit question')
       cy.visit(`/questions/${question.slug}`)
-      cy.title().should('eq', question.title);
+      cy.title().should('eq', question.title)
 
       cy.step('All metadata visible')
       cy.contains(`${question.subscribers.length} following`)

diff --git a/src/pages/Question/QuestionListing.tsx b/src/pages/Question/QuestionListing.tsx
@@ -28,6 +28,7 @@ export const QuestionListing = () => {
   const sort = searchParams.get('sort') as QuestionSortOptions
 
   useEffect(() => {
+    document.title = 'Questions'
     if (!sort) {
       // ensure sort is set
       const params = new URLSearchParams(searchParams.toString())

diff --git a/src/pages/Question/QuestionPage.tsx b/src/pages/Question/QuestionPage.tsx
@@ -14,7 +14,6 @@ import { TagList } from 'src/common/Tags/TagsList'
 import { useQuestionStore } from 'src/stores/Question/question.store'
 import { formatImagesForGallery } from 'src/utils/formatImageListForGallery'
 import { buildStatisticsLabel } from 'src/utils/helpers'
-import { incrementViewCount } from 'src/utils/incrementViewCount'
 import { Box, Button, Card, Divider, Flex, Heading, Text } from 'theme-ui'
 
 import { ContentAuthorTimestamp } from '../common/ContentAuthorTimestamp/ContentAuthorTimestamp'
@@ -49,13 +48,10 @@ export const QuestionPage = () => {
       }
 
       store.activeQuestionItem = foundQuestion
-      incrementViewCount({
-        document: foundQuestion,
-        documentType: 'question',
-        store,
-      })
+      store.incrementViewCount(foundQuestion._id)
 
       setQuestion(foundQuestion)
+      document.title = foundQuestion.title
       setIsLoading(false)
     }
 
@@ -82,7 +78,6 @@ export const QuestionPage = () => {
         <Loader />
       ) : question ? (
         <>
-        {document.title = question.title}
           <Card sx={{ position: 'relative', marginTop: 4 }}>
             <Flex sx={{ flexDirection: 'column', padding: 4, gap: 2 }}>
               <Flex sx={{ flexWrap: 'wrap', gap: 2 }}>
@@ -161,7 +156,7 @@ export const QuestionPage = () => {
                 {
                   icon: 'view',
                   label: buildStatisticsLabel({
-                    stat: question.total_views,
+                    stat: question.total_views || 0,
                     statUnit: 'view',
                     usePlural: true,
                   }),