questions: title of the tab changes

ONEARMY · May 2, 2024 · c39adee · c39adee
1 parent 8f8c16a
commit c39adee
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 1 deletion.
diff --git a/packages/cypress/src/integration/questions/read.spec.ts b/packages/cypress/src/integration/questions/read.spec.ts
@@ -32,6 +32,7 @@ describe('[Questions]', () => {
 
       cy.step('Can visit question')
       cy.visit(`/questions/${question.slug}`)
+      cy.title().should('eq', question.title);
 
       cy.step('All metadata visible')
       cy.contains(`${question.subscribers.length} following`)

diff --git a/src/pages/Question/QuestionListItem.tsx b/src/pages/Question/QuestionListItem.tsx
@@ -37,7 +37,6 @@ export const QuestionListItem = ({ question, query }: IProps) => {
         e.stopPropagation()
         e.preventDefault()
         navigate(url)
-        document.title = title;
       }}
       data-href={url}
       tabIndex={0}

diff --git a/src/pages/Question/QuestionPage.tsx b/src/pages/Question/QuestionPage.tsx
@@ -82,6 +82,7 @@ export const QuestionPage = () => {
         <Loader />
       ) : question ? (
         <>
+        {document.title = question.title}
           <Card sx={{ position: 'relative', marginTop: 4 }}>
             <Flex sx={{ flexDirection: 'column', padding: 4, gap: 2 }}>
               <Flex sx={{ flexWrap: 'wrap', gap: 2 }}>