Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readr local edition downgrade #495

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

katy-sadowski
Copy link
Collaborator

Workaround for a bug in vroom (tidyverse/vroom#519) which is causing test failures in R CMD Check on MacOS, and may also cause errors for users in certain circumstances (the bug is still not well understood). The solution follows what was done in a Bioconductor package here, and this seems like a legit fix, as the 1st edition of readr is still supported and the main change between editions seems to be the switch to use vroom. The csvs we're reading in DQD are small so I don't have performance concerns.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7a2b489) 85.95% compared to head (e1236a6) 85.52%.
Report is 11 commits behind head on develop.

❗ Current head e1236a6 differs from pull request most recent head ca1a941. Consider uploading reports for the commit ca1a941 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #495      +/-   ##
===========================================
- Coverage    85.95%   85.52%   -0.43%     
===========================================
  Files           15       15              
  Lines          847      850       +3     
===========================================
- Hits           728      727       -1     
- Misses         119      123       +4     
Files Coverage Δ
R/convertResultsCase.R 100.00% <100.00%> (ø)
R/executeDqChecks.R 89.71% <100.00%> (-1.67%) ⬇️
R/listChecks.R 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katy-sadowski katy-sadowski merged commit cd5bd33 into OHDSI:develop Oct 18, 2023
4 checks passed
@katy-sadowski katy-sadowski deleted the katy__vroom_fix branch October 18, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant