Issue #1645 Interface Support Mock Testing #2215

kccarter76 · 2020-07-01T00:14:33Z

Issues

Feature enhancement resolves #1645

Description

added the ability to use an interface IODataQueryOptions as a parameter on a controller method.

Checklist (Uncheck if it is not completed)

Test cases added
Build and test with one-click build and test script passed

Additional work necessary

feature needs to still be documented and the issue #1645 updated with Docs Needed.

…he injection occurs

Dev/issue 1645

OData#1645 unit test added and all unit tests passing

…ings base on vs studio.

kccarter76 · 2020-07-01T00:58:30Z

Base line file test\UnitTest\Microsoft.AspNet.OData.Test\PublicApi\Microsoft.AspNet.OData.PublicApi.bsl and output file D:\a\1\s\bin\Release\UnitTest\AspNet\Microsoft.AspNet.OData.PublicApi.out do not match, please check.
To update the baseline, please run:

copy /y "D:\a\1\s\bin\Release\UnitTest\AspNet\Microsoft.AspNet.OData.PublicApi.out" "test\UnitTest\Microsoft.AspNet.OData.Test\PublicApi\Microsoft.AspNet.OData.PublicApi.bsl"

I am going to need some help on your side to address this issue.

one thing I can try, may not work though

[xUnit.net 00:00:00.00] xUnit.net VSTest Adapter v2.4.2+2d84eb3141 (32-bit Desktop .NET 4.0.30319.42000)
[xUnit.net 00:00:00.59] Skipping: Microsoft.AspNet.OData.Test (could not find dependent assembly 'Microsoft.AspNet.OData.Test, Version=7.4.1')
No test matches the given testcase filter FullyQualifiedName=Microsoft.AspNet.OData.Test.ApplyTest.Apply_Works_WithNonODataJson|FullyQualifiedName=Microsoft.AspNet.OData.Test.ApplyTest.Apply_Works_WithODataJson|FullyQualifiedName=Microsoft.AspNet.OData.Test.ClrPropertyInfoAnnotationTest.Ctor_Throw... in D:\Source\home\WebApi\bin\Release\UnitTest\AspNet\Microsoft.AspNet.OData.Test.dll

build.cmd quick is not even executing the AspNet 4.5.2 framework version of the testing.

the key was to set the processor architecture from auto to x64 for any cpu

src/Microsoft.AspNet.OData.Shared/Interfaces/IWebApiContext.cs

src/Microsoft.AspNet.OData.Shared/Query/Validators/ODataQueryValidator.cs

src/Microsoft.AspNetCore.OData/Query/ODataQueryOptionsOfTEntity.cs

.../Microsoft.AspNet.OData.Test.Shared/Formatter/SUT/CollectionSerializerCustomersController.cs

marabooy · 2020-09-03T08:28:10Z

@kccarter76 Thank you for your contribution, Kindly address the above comments.

kccarter76 · 2020-11-17T20:18:23Z

I do not have write access to the destination branch. the conflicts that are currently listed are a product of natural development and where not present at the time this was completed. I may not have the time available to address.

marabooy

Looks good to me, I didn't find any apparent issues with backwards compatibility.
@kccarter76 Do let me know when you are ready to get this merged in and any help you require.

marabooy · 2020-12-07T09:23:08Z

.../Microsoft.AspNet.OData.Test.Shared/Formatter/SUT/CollectionSerializerCustomersController.cs

+    }
+}
+
+namespace Microsoft.AspNet.OData.Test.Formatter.Interface


Split this to two namespaces for consistency.

not sure about what you are asking here? been awhile since looking at this code.

I think you are asking about the sut class version in a class namespace and the interface implementation in an interface namespace. is that correct?

it might be best to split into two separate files to simplify reading the code base.

I need more eyes on this, since I have been unable to resolve the issue with the unit tests not running. @marabooy, I have sent you a collaboration request. I have hit a road block and the work crews appear to be on a permanent coffee break.

…te files.

kccarter76 · 2021-01-15T05:04:57Z

to resolve the above conflicts, it would be best to collaborate. I am not sure what needs to be kept and merge what is needed to support the interface. EnableQueryAttribute was straight forward. however the others not so much.

marabooy · 2021-01-15T06:55:00Z

@kccarter76 the BSL updates can be done by running the respective PublicApi tests and copying over the new file.
Checkout the public api test linked here

kccarter76 · 2021-01-15T16:56:16Z

I am missing code for RequestQueryData. I may need to merge/pull the current master into my github fork. okay my EnableQueryAttribute is really out of sync with the base master and when I try to create a pull request from webApi:master to kccarter76webapi:master.

…aster # Conflicts: # src/Microsoft.AspNetCore.OData/EnableQueryAttribute.cs # test/UnitTest/Microsoft.AspNet.OData.Test/PublicApi/Microsoft.AspNet.OData.PublicApi.bsl # test/UnitTest/Microsoft.AspNetCore.OData.Test/PublicApi/Microsoft.AspNetCore.OData.PublicApi.bsl # test/UnitTest/Microsoft.AspNetCore.OData.Test/PublicApi/Microsoft.AspNetCore3x.OData.PublicApi.bsl

kccarter76 · 2021-01-15T18:23:44Z

is this being addressed in the AspNet solution:

Severity Code Description Project File Line Suppression State
Warning CA0507 Post-build Code Analysis (FxCopCmd.exe) has been deprecated in favor of FxCop analyzers, which run during build. Refer to https://aka.ms/fxcopanalyzers to migrate to FxCop analyzers. Active

this exception is preventing me from updating 'Microsoft.AspNet.OData.PublicApi.bsl'

Severity Code Description Project File Line Suppression State
Error CA0001 CA0001 : Exception of type 'Phx.FatalError' was thrown. Active

was able to git this worked around by not running code analysis. however, the x unit tests are not running again and the work around from before is not working.

microsoft/vstest#1220

marabooy · 2021-01-19T07:46:21Z

test/UnitTest/Microsoft.AspNet.OData.Test/PublicApi/Microsoft.AspNet.OData.PublicApi.bsl

@@ -2354,9 +2354,48 @@ public enum Microsoft.AspNet.OData.Query.SelectExpandType : int {
 	Disabled = 2
 }

+<<<<<<< HEAD


Kindly fix the merge result here. I will check with someone on the team to see what can be done to help.

working on it, currently dealing with an issue where VS 2019 16.8 will not run unit tests on local machine. see tail end of microsoft/vstest#1220

corranrogue9 · 2021-10-23T21:38:02Z

src/Microsoft.AspNet.OData.Shared/Interfaces/IODataQueryOptions.cs

+    /// </summary>
+    [ODataQueryParameterBinding]
+    [NonValidatingParameterBinding]
+    public interface IODataQueryOptions


This is more of a discussion than feedback: I came into this review not really knowing what query options were, and saw that the purpose was to convert it to an interface for mocking. I wondered to myself "how many ways really are there to implement a set of options? won't that just be a data type with a bunch of data type properties? there should just be a constructor overload where anything that needs to be mocked can be set directly instead". Seeing this interface, though, I see the many methods that are useful for the query options. I'm wondering, though, if it makes sense to separate those two things out. In this case, I would think the ApplyTo overloads belong on some other type rather than the options themselves. Do you have any thoughts on this?

BabaDorin · 2021-11-27T11:08:36Z

Any updates?

drmcclelland · 2022-12-09T21:13:13Z

Any updates @kccarter76 ?

kccarter76 added 21 commits June 29, 2020 16:09

OData#1645 okay this is the easy part, now I get to hunt down where t…

34c5ec9

…he injection occurs

Create dotnet-core.yml

74a4d3a

Update dotnet-core.yml

97340aa

Update dotnet-core.yml

06f2992

Update dotnet-core.yml

4bc104a

Update dotnet-core.yml

7bd2fe9

Update dotnet-core.yml

4998dc8

trying to get the github integration server building this code

9a1c79d

OData#1645

c42f738

linux is very picky about names

4f0872d

Update dotnet-core.yml

a774ae3

Rename ProductsCSDL.xml to ProductsCsdl.xml

8d08fbe

no message

090f996

local test run completes succesful

691a0ef

Merge pull request #5 from kccarter76/dev/issue-1645

f80cb57

Dev/issue 1645

OData#1645 unit test added and all unit tests passing

fa89897

Merge pull request #6 from kccarter76/dev/issue-1645

d6f43e4

OData#1645 unit test added and all unit tests passing

Delete dotnet-core.yml

304be77

remove the code that the designer did not

8b1f5a2

OData#1645 moved the interfaces to the shared project and adjusted th…

ed6d0b9

…ings base on vs studio.

OData#1645 updated the EnableQueryAttribute for AspNet

0c22e8e

OData#1645 finally was able to generate the bsl

00da586

marabooy requested review from xuzhg, marabooy, ElizabethOkerio, gathogojr, habbes, KenitoInc and Sreejithpin August 11, 2020 16:51

marabooy added the Ready for review Use this label if a pull request is ready to be reviewed label Aug 11, 2020

marabooy requested changes Sep 3, 2020

View reviewed changes

kccarter76 added 2 commits September 3, 2020 10:55

update code files based on comments by marabooy

66e8f9a

per maraboy removed the notsupported exception

b8fc39e

kccarter76 requested a review from marabooy November 17, 2020 20:15

marabooy added this to the 7.5.2 milestone Nov 24, 2020

marabooy reviewed Dec 7, 2020

View reviewed changes

kccarter76 requested a review from marabooy January 14, 2021 22:12

seperated the interface and class name space for this sut into sepera…

0198ea4

…te files.

kccarter76 added 2 commits January 15, 2021 10:36

resolved conflicts

127a7d9

kccarter76 added 2 commits January 15, 2021 11:26

no message

6567621

resolve conflct

ddffb5d

marabooy requested changes Jan 19, 2021

View reviewed changes

corranrogue9 reviewed Oct 23, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue #1645 Interface Support Mock Testing #2215

Issue #1645 Interface Support Mock Testing #2215

kccarter76 commented Jul 1, 2020 •

edited

Loading

kccarter76 commented Jul 1, 2020 •

edited

Loading

marabooy commented Sep 3, 2020

kccarter76 commented Nov 17, 2020

marabooy left a comment

marabooy Dec 7, 2020

kccarter76 Jan 14, 2021

kccarter76 Jan 14, 2021

kccarter76 Jan 14, 2021

kccarter76 Mar 25, 2021

kccarter76 commented Jan 15, 2021

marabooy commented Jan 15, 2021

kccarter76 commented Jan 15, 2021 •

edited

Loading

kccarter76 commented Jan 15, 2021 •

edited

Loading

marabooy Jan 19, 2021 •

edited

Loading

kccarter76 Jan 19, 2021

corranrogue9 Oct 23, 2021

BabaDorin commented Nov 27, 2021

drmcclelland commented Dec 9, 2022

Issue #1645 Interface Support Mock Testing #2215

Are you sure you want to change the base?

Issue #1645 Interface Support Mock Testing #2215

Conversation

kccarter76 commented Jul 1, 2020 • edited Loading

Issues

Description

Checklist (Uncheck if it is not completed)

Additional work necessary

kccarter76 commented Jul 1, 2020 • edited Loading

marabooy commented Sep 3, 2020

kccarter76 commented Nov 17, 2020

marabooy left a comment

Choose a reason for hiding this comment

marabooy Dec 7, 2020

Choose a reason for hiding this comment

kccarter76 Jan 14, 2021

Choose a reason for hiding this comment

kccarter76 Jan 14, 2021

Choose a reason for hiding this comment

kccarter76 Jan 14, 2021

Choose a reason for hiding this comment

kccarter76 Mar 25, 2021

Choose a reason for hiding this comment

kccarter76 commented Jan 15, 2021

marabooy commented Jan 15, 2021

kccarter76 commented Jan 15, 2021 • edited Loading

kccarter76 commented Jan 15, 2021 • edited Loading

marabooy Jan 19, 2021 • edited Loading

Choose a reason for hiding this comment

kccarter76 Jan 19, 2021

Choose a reason for hiding this comment

corranrogue9 Oct 23, 2021

Choose a reason for hiding this comment

BabaDorin commented Nov 27, 2021

drmcclelland commented Dec 9, 2022

kccarter76 commented Jul 1, 2020 •

edited

Loading

kccarter76 commented Jul 1, 2020 •

edited

Loading

kccarter76 commented Jan 15, 2021 •

edited

Loading

kccarter76 commented Jan 15, 2021 •

edited

Loading

marabooy Jan 19, 2021 •

edited

Loading