Support extension method as Navigation property #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhg
requested review from
raheph,
mikepizzo,
xuzhg,
AlanWong-MS and
biaol-odata
xuzhg
reviewed
Jul 16, 2018
src/Microsoft.AspNet.OData.Shared/Builder/PropertyDescriptor.cs
Outdated
Show resolved
Hide resolved
xuzhg
reviewed
Jul 16, 2018
src/Microsoft.AspNet.OData.Shared/Builder/PropertyDescriptor.cs
Outdated
Show resolved
Hide resolved
xuzhg
reviewed
Jul 16, 2018
src/Microsoft.AspNet.OData.Shared/Builder/PropertyDescriptor.cs
Outdated
Show resolved
Hide resolved
xuzhg
reviewed
Jul 16, 2018
src/Microsoft.AspNet.OData.Shared/Builder/PropertyDescriptor.cs
Outdated
Show resolved
Hide resolved
|
I fix it in commit genusP@da30e83 Why this commit not showing in PR |
xuzhg
reviewed
Jul 17, 2018
xuzhg
reviewed
Jul 17, 2018
xuzhg
reviewed
Jul 17, 2018
xuzhg
reviewed
Jul 17, 2018
xuzhg
reviewed
Jul 17, 2018
genusP
force-pushed
the
nav_prop_as_extension_method
branch
3 times, most recently
from
8fb28db
to
b347a48
Compare
genusP
force-pushed
the
nav_prop_as_extension_method
branch
from
b347a48
to
674d25f
Compare
|
Unnecessary files deleted (commit genusP/WebApi@da30e83 replaced) |
|
I hope, you add this feature |
|
@xuzhg, Any questions by this PR? |
…as_extension_method # Conflicts: # src/Microsoft.AspNet.OData.Shared/Formatter/EdmLibHelpers.cs # src/Microsoft.AspNet.OData.Shared/Microsoft.AspNet.OData.Shared.projitems
|
@mikepizzo, please review this PR. |
|
@KanishManuja-MS Please, give me information about CI errors. |
|
|
|
@KanishManuja-MS Please, give me information about CI errors. |
|
@genusP Style issues - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Some ORMs (e.g. linq2db) support define navigation properties as extension method.
This PR add functional to model builder and also update binders for support this.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.