Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][ADD] pos_loyalty_exclude #1217

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][ADD] pos_loyalty_exclude #1217

wants to merge 1 commit into from

Conversation

trisdoan
Copy link
Contributor

@trisdoan trisdoan commented Jul 9, 2024

No description provided.

Ricardoalso
Ricardoalso approved these changes Jul 10, 2024
View reviewed changes
pos_loyalty_exclude/models/loyalty_rule.py
rule.product_ids
or rule.product_category_id
or rule.product_tag_id
or rule.product_domain not in ("[]", "[['sale_ok', '=', True]]")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is [['sale_ok', '=', True]] intended or do you meant [('sale_ok', '=', True)]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Ricardoalso, it is intended as it is in https://github.com/odoo/odoo/blob/def7c93c6c05e1814d6221cf90e93bdd8867e473/addons/pos_loyalty/models/loyalty_rule.py#L29

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@trisdoan trisdoan force-pushed the 16.0-add-pos_loyalty_exclude branch from 3140a53 to 8039559 Compare July 16, 2024 02:36
@ivantodorovich
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1217-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 18, 2024
@OCA-git-bot
Merge PR #1217 into 16.0
99a7cfd 
Signed-off-by ivantodorovich
@OCA-git-bot
Copy link
Contributor

@ivantodorovich your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1217-by-ivantodorovich-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk
Copy link

#1236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilshamerlinck nilshamerlinck nilshamerlinck left review comments

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@Ricardoalso Ricardoalso Ricardoalso approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trisdoan @OCA-git-bot @ivantodorovich @simahawk @nilshamerlinck @cyrilmanuel @Ricardoalso